Re: [LTP] [PATCH] add clock_gettime04

[chrubis@suse.cz]

Hi!
> Is it implemented? I don't see any lib function handling it:
> 
> $ grep "TRERRNO" -r .
> ./include/tst_res_flags.h:#define TRERRNO       0x300   /* Capture errno information from TEST_RETURN to

I would call that a bug, feel free to push a patch fixing this.

> > > +	if (opt_testtime) {
> > > +		testtime = atoi(opt_testtimestr);
> > > +		if (testtime <= 0) {
> > > +			tst_brkm(TBROK, NULL, "Invalid arg for -T: %s",
> > > +				opt_testtimestr);
> > > +		}
> > > +	}
> > > +
> > > +	setup();
> > > +
> > > +	test(testtime);
> > 
> > Shouldn't the test(testtime) be still inside the for () loop with
> > TEST_LOOPING() because otherwise the test will gladly accept and ignore
> > the standard parameters (-i -I etc).
> 
> I thought the -T would cover both, but I can add it back, with some
> check to break that loop if anything fails.

It would and wouldn't. Functionally it would, but the test would accept
parameters that are completly ignored, which is bug from a user
perspective.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list