From: chrubis@suse.cz
To: Zorro Lang <zlang@redhat.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] ext4-new-features: modify ext4-delalloc-mballoc can not find ffsb-config file
Date: Mon, 29 Sep 2014 17:14:46 +0200 [thread overview]
Message-ID: <20140929151446.GA11687@rei> (raw)
In-Reply-To: <1412002661-14537-1-git-send-email-zlang@redhat.com>
Hi!
> diff --git a/testcases/kernel/fs/ext4-new-features/ext4-delalloc-mballoc/ext4-alloc-test.sh b/testcases/kernel/fs/ext4-new-features/ext4-delalloc-mballoc/ext4-alloc-test.sh
> index 1ffba13..47d9174 100755
> --- a/testcases/kernel/fs/ext4-new-features/ext4-delalloc-mballoc/ext4-alloc-test.sh
> +++ b/testcases/kernel/fs/ext4-new-features/ext4-delalloc-mballoc/ext4-alloc-test.sh
> @@ -40,7 +40,7 @@ ext4_test_remount()
> return
> fi
>
> - ffsb ffsb-config0 > /dev/null
> + ffsb $LTPROOT/testcases/bin/ffsb-config0 > /dev/null
> if [ $? -ne 0 ]; then
> tst_resm TFAIL "ffsb returned failure"
> umount mnt_point
> @@ -92,7 +92,7 @@ ext4_test_delalloc_mballoc()
> return
> fi
>
> - ffsb ffsb-config$2 > /dev/null
> + ffsb $LTPROOT/testcases/bin/ffsb-config$2 > /dev/null
These should idealy be treated as a datafiles.
So the ext4-ffsb-config/Makefile should have:
INSTALL_DIR := testcases/data/ext4-ffsb/
then the files would be installed under this path and the
path to the files in the shell script above should then be
$LTPROOT/testcases/data/ext4-ffsb/ffsb-config0
Can you please update the patch?
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Slashdot TV. Videos for Nerds. Stuff that Matters.
http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2014-09-29 15:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 14:57 [LTP] [PATCH] ext4-new-features: modify ext4-delalloc-mballoc can not find ffsb-config file Zorro Lang
2014-09-29 15:14 ` chrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929151446.GA11687@rei \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox