[LTP] [PATCH] ext4-new-features: modify ext4-delalloc-mballoc can not find ffsb-config file

[LTP] [PATCH] ext4-new-features: modify ext4-delalloc-mballoc can not find ffsb-config file

[Zorro Lang]

run ext4-delalloc-mballoc always hit "ffsb-config0: No such file or directory",
so add $LTPROOT/testcases/bin/ for ffsb-config.

Signed-off-by: Zorro Lang <zlang@redhat.com>
---

Hi,

`ffsb ffsb-config$2` always hit "ffsb-config, No such file", I have to use
absolute pathname for ffsb-config. Is it OK?

Thank you,
Zorro Lang

 .../fs/ext4-new-features/ext4-delalloc-mballoc/ext4-alloc-test.sh     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/testcases/kernel/fs/ext4-new-features/ext4-delalloc-mballoc/ext4-alloc-test.sh b/testcases/kernel/fs/ext4-new-features/ext4-delalloc-mballoc/ext4-alloc-test.sh
index 1ffba13..47d9174 100755
--- a/testcases/kernel/fs/ext4-new-features/ext4-delalloc-mballoc/ext4-alloc-test.sh
+++ b/testcases/kernel/fs/ext4-new-features/ext4-delalloc-mballoc/ext4-alloc-test.sh
@@ -40,7 +40,7 @@ ext4_test_remount()
 		return
 	fi
 
-	ffsb ffsb-config0 > /dev/null
+	ffsb $LTPROOT/testcases/bin/ffsb-config0 > /dev/null
 	if [ $? -ne 0 ]; then
 		tst_resm TFAIL "ffsb returned failure"
 		umount mnt_point
@@ -92,7 +92,7 @@ ext4_test_delalloc_mballoc()
 		return
 	fi
 
-	ffsb ffsb-config$2 > /dev/null
+	ffsb $LTPROOT/testcases/bin/ffsb-config$2 > /dev/null
 	if [ $? -ne 0 ]; then
 		tst_resm TFAIL "ffsb returned failure"
 		umount mnt_point
-- 
1.9.3


------------------------------------------------------------------------------
Slashdot TV.  Videos for Nerds.  Stuff that Matters.
http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] ext4-new-features: modify ext4-delalloc-mballoc can not find ffsb-config file

[chrubis]

Hi!
> diff --git a/testcases/kernel/fs/ext4-new-features/ext4-delalloc-mballoc/ext4-alloc-test.sh b/testcases/kernel/fs/ext4-new-features/ext4-delalloc-mballoc/ext4-alloc-test.sh
> index 1ffba13..47d9174 100755
> --- a/testcases/kernel/fs/ext4-new-features/ext4-delalloc-mballoc/ext4-alloc-test.sh
> +++ b/testcases/kernel/fs/ext4-new-features/ext4-delalloc-mballoc/ext4-alloc-test.sh
> @@ -40,7 +40,7 @@ ext4_test_remount()
>  		return
>  	fi
>  
> -	ffsb ffsb-config0 > /dev/null
> +	ffsb $LTPROOT/testcases/bin/ffsb-config0 > /dev/null
>  	if [ $? -ne 0 ]; then
>  		tst_resm TFAIL "ffsb returned failure"
>  		umount mnt_point
> @@ -92,7 +92,7 @@ ext4_test_delalloc_mballoc()
>  		return
>  	fi
>  
> -	ffsb ffsb-config$2 > /dev/null
> +	ffsb $LTPROOT/testcases/bin/ffsb-config$2 > /dev/null

These should idealy be treated as a datafiles.

So the ext4-ffsb-config/Makefile should have:

INSTALL_DIR := testcases/data/ext4-ffsb/

then the files would be installed under this path and the
path to the files in the shell script above should then be
$LTPROOT/testcases/data/ext4-ffsb/ffsb-config0

Can you please update the patch?

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Slashdot TV.  Videos for Nerds.  Stuff that Matters.
http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list