[LTP] [PATCH] fs/ext4-inode-version: remove "./" before "ext4_get_inode_version.sh" in ext4_test_inode_version.c

[LTP] [PATCH] fs/ext4-inode-version: remove "./" before "ext4_get_inode_version.sh" in ext4_test_inode_version.c

[Zorro Lang]

when I test with ext4-inode-version, I always get "sh ./ext4_get_inode_version.sh: No such file".
Then I removed "./" of "ext4_get_inode_version.sh" in ext4_test_inode_version.c, everything
goes well.

Signed-off-by: Zorro Lang <zlang@redhat.com>
---

Hi,

As I said above. I don't know why the case want to use "./ext4_get_inode_version.sh", I just tried to
remove "./", and run pass. Please review it.

Thank you,
Zorro Lang

 .../fs/ext4-new-features/ext4-inode-version/ext4_test_inode_version.c   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_test_inode_version.c b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_test_inode_version.c
index 168f5ce..533f694 100644
--- a/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_test_inode_version.c
+++ b/testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_test_inode_version.c
@@ -41,7 +41,7 @@ int get_inode_version(void)
 {
 	char buf[1024];
 
-	sprintf(buf, "./ext4_get_inode_version.sh %s 1", filename);
+	sprintf(buf, "ext4_get_inode_version.sh %s 1", filename);
 
 	/* sync before run debugfs to get inode version */
 	sync();
-- 
1.9.3


------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] fs/ext4-inode-version: remove "./" before "ext4_get_inode_version.sh" in ext4_test_inode_version.c

[chrubis]

Hi!
> when I test with ext4-inode-version, I always get "sh ./ext4_get_inode_version.sh: No such file".
> Then I removed "./" of "ext4_get_inode_version.sh" in ext4_test_inode_version.c, everything
> goes well.

That is a valid fix because:

1. It is not guaranteed that test working directory is
$LTPDIR/testcases/bin

2. It is guaranteed that $LTPDIR/testcases/bin is in $PATH

Please resend with a changelog that simply says remove ./ from
./ext4_get_inode_version.sh in ext4_test_inode_version.c.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Slashdot TV.  Videos for Nerds.  Stuff that Matters.
http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] fs/ext4-inode-version: remove "./" before "ext4_get_inode_version.sh" in ext4_test_inode_version.c

[chrubis]

Hi!
> Glad to hear that this is a valid fix. I have re-sent the patch, please 
> check.

Both pushed, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Slashdot TV.  Videos for Nerds.  Stuff that Matters.
http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list