Re: [LTP] [PATCH v2] ltp-networking/tcp_cmds/finger: fix finger bad user and host test

[Hangbin Liu <liuhangbin@gmail.com>]

On Mon, Sep 29, 2014 at 08:37:30PM +0400, Alexey Kodanev wrote:
> Hi!
> 
> On 09/25/2014 04:59 PM, Hangbin Liu wrote:
> >Finger always return 0 with bad user and host test. And it also return
> >different error message on different distros. So let's only check stderr
> >message and decide whether the test pass or fail.
> >
> >Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> >---
> >  testcases/network/tcp_cmds/finger/finger01 | 9 +++------
> >  1 file changed, 3 insertions(+), 6 deletions(-)
> >
> >diff --git a/testcases/network/tcp_cmds/finger/finger01 b/testcases/network/tcp_cmds/finger/finger01
> >index 203d746..89693ff 100755
> >--- a/testcases/network/tcp_cmds/finger/finger01
> >+++ b/testcases/network/tcp_cmds/finger/finger01
> >@@ -115,13 +115,10 @@ do_test2()
> >      finger -x 2>&1 1>/dev/null && end_testcase "finger -x should fail"
> 
> I would change redirection here to  > /dev/null 2>&1 as we don't need to
> print stderr.

Yes, will correct it.
> 
> >      tst_resm TINFO "finger -bad user "
> >-    finger $BADUSER 2>&1 1>/dev/null || end_testcase "finger $BADUSER"
> >-    finger @$BADHOST 2>&1 1>/dev/null | grep "finger: unknown host" \
> >-        || end_testcase "finger @$BADHOST"
> >-    if ! finger $BADUSER@$BADHOST 2>&1 1>/dev/null \
> >-        | grep "finger: unknown host"; then
> >+    [ "finger $BADUSER 2>&1 1>/dev/null" ] || end_testcase "finger $BADUSER"
> >+    [ "finger @$BADHOST 2>&1 1>/dev/null" ] || end_testcase "finger @$BADHOST"
> >+    [ "finger $BADUSER@$BADHOST 2>&1 1>/dev/null" ] || \
> 
> Checking string constants... not command output, forgot to add '$()'?

Opps, sorry for the stupid mistake.

> 
> Besides, it'd be great to get rid of obsolete 'net_cmdlib.sh' in the test.

OK, I will send another patch to clean up net_cmdlib.sh and mv read_opts() to
test_net.sh

-- 

Thanks & Best Regards
Hangbin Liu <liuhangbin@gmail.com>

------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list