Re: [LTP] recvfrom01: fix test for invalid message flags

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> The recv tests were making invalid assumptions about how flags are
> checked by the kernel. (It makes no explicit tests for invalid flags
> or combinations of flags.) [1] So the current method of setting every
> possible flag and checking for a specific error is not valid.
> 
> Before kernel 3.17 we were effectively just testing having the MSG_OOB
> flag set with no out-of-band data available. With 3.17 and later we
> were testing having MSG_ERRQUEUE set with no error data available,
> which returns a different error (and causes the existing test to fail).
> 
> Replace the bogus test for invalid flags with two new tests that check
> return codes for invalid MSG_OOB and MSG_ERRQUEUE flags.
> 
> Note that this introduces a failure on kernels before 3.17, which has
> a bug fix for MSG_ERRQUEUE flag handling. This failure is a legitimate
> bug on these older kernels. (They should not be returning success with
> no data available.)

Sorry for the delay, acked, tested and pushed, thanks.

Will you also send similar patches for the rest of the recv testcases?

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list