Re: [LTP] [PATCH] containers: added mountns/mountns05.c

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
I do not like these macros.

> +#define REPORT_PARENT_ERROR(errmsg) \
> +{ \
> +	msgctl(id, IPC_RMID, NULL); \

	^
	This should be removed from the test cleanup.

	If you want to call the default cleanup defined in the header
	you can define second cleanup function that does specific
	cleanup and then calls the generic cleanup pass the right
	function pointers to tst_brmk()

> +	tst_brkm(TBROK | TERRNO, cleanup, errmsg); \
> +}
> +
> +#define REPORT_CHLD_ERROR(errmsg) \
> +{ \
> +	perror(errmsg); umount(DIRA); \
> +	msgctl(id, IPC_RMID, NULL); \
> +	wait(&status); return ERRC; \
> +}

Can't we do the cleanup the kenel style?

i.e.

	if (something_failed()) {
		errmsg = "message";
		goto err;
	}

	...

	return result;
err:
	perror(errmsg);
	umout(DIRA);
	msgclt(id, IPC_RMID, NULL);
	wait(&status);
	return ERRC;


...

> diff --git a/testcases/kernel/containers/mountns/mountns_helper.h b/testcases/kernel/containers/mountns/mountns_helper.h
> index d4a6a91..d82c837 100644
> --- a/testcases/kernel/containers/mountns/mountns_helper.h
> +++ b/testcases/kernel/containers/mountns/mountns_helper.h
> @@ -47,6 +47,10 @@ static int check_newns(void)
>  
>  static void cleanup(void)
>  {
> +	int status;
> +
> +	wait(&status);
> +	umount(DIRA);
>  	umount(DIRA);
>  	umount(DIRB);
>  	tst_rmdir();

This changes function called from several testcases, I guess that this
is missing cleanup being added there. Maybe it should deserve to be
pushed as a separate patch with description in commit message.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list