public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Jan Kara <jack@suse.cz>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v2] syscalls/fanotify: Verify that inode ignore masks are properly reflected
Date: Tue, 11 Nov 2014 15:09:18 +0100	[thread overview]
Message-ID: <20141111140917.GB32196@rei> (raw)
In-Reply-To: <20141111135224.GE10456@quack.suse.cz>

Hi!
> > > Verify that when inode has an ignore mask set, it is properly reflected
> > > when notifying a mountpoint. The test verifies fix "fanotify: Fix notification
> > > of groups with inode & mount marks" in the Linux kernel.
> > > 
> > > Signed-off-by: Jan Kara <jack@suse.cz>
> > 
> > Pushed with small change to get rid of another signed vs unsigned
> > comparsion warning.
>   Yeah. BTW those warnings are pretty annoying and the number of false
> positives is IHMO too large for the warning to be useful...

Well they come with the gcc -W flag (nowadays called -Wextra). We may be
able to disable these with -Wno-sign-compare but don't want to play
whack a mole trying to figure out which warnings are useful. I doubt
that this is worth the effort and since we do not use -Werror these are
just mildly annoying. Or do you have a better idea?

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://pubads.g.doubleclick.net/gampad/clk?id=154624111&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

      parent reply	other threads:[~2014-11-11 14:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1415639518-4906-1-git-send-email-jack@suse.cz>
2014-11-11  2:32 ` [LTP] [PATCH v2] syscalls/fanotify: Verify that inode ignore masks are properly reflected Zeng Linggang
2014-11-11  9:33   ` Cyril Hrubis
2014-11-11 12:13 ` Cyril Hrubis
     [not found]   ` <20141111135224.GE10456@quack.suse.cz>
2014-11-11 14:09     ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141111140917.GB32196@rei \
    --to=chrubis@suse.cz \
    --cc=jack@suse.cz \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox