Re: [LTP] [PATCH] syscalls/getgroups/getgroups01: set supplementary groups to prevent TCONF

[Han Pingtian <hanpt@linux.vnet.ibm.com>]

On Thu, Dec 04, 2014 at 05:44:14AM -0500, Jan Stancek wrote:
> ----- Original Message -----
> > From: "Cyril Hrubis" <chrubis@suse.cz>
> > To: ltp-list@lists.sourceforge.net
> > Sent: Thursday, 4 December, 2014 11:17:41 AM
> > Subject: Re: [LTP] [PATCH] syscalls/getgroups/getgroups01: set supplementary groups to prevent TCONF
> > 
> > Hi!
> > > Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
> > > ---
> > >  testcases/kernel/syscalls/getgroups/getgroups01.c | 5 +++--
> > >  1 file changed, 3 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/testcases/kernel/syscalls/getgroups/getgroups01.c
> > > b/testcases/kernel/syscalls/getgroups/getgroups01.c
> > > index 9fb4c98..28559d3 100644
> > > --- a/testcases/kernel/syscalls/getgroups/getgroups01.c
> > > +++ b/testcases/kernel/syscalls/getgroups/getgroups01.c
> > > @@ -74,8 +74,6 @@ int main(int ac, char **av)
> > >  	int i;
> > >  	int entries;
> > >  
> > > -	initgroups("root", 0);
> > > -
> > >  	if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
> > >  		tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
> > >  
> > > @@ -183,6 +181,9 @@ static void setup(void)
> 
> I'd add tst_require_root() to setup, since setgroups() requires CAP_SETGID.

I think getgroups() doesn't need privileged power, so we shouldn't limit
this case with tst_require_root, because this case is testing
getgroups(). With this patch applied, if run by unprivileged user, 3#
will fail by TCONF, but other tests will pass.

Thanks.


------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list