Re: [LTP] [PATCH v2] syscalls/getgroups/getgroups01: set supplementary groups to prevent TCONF

[Han Pingtian <hanpt@linux.vnet.ibm.com>]

On Thu, Dec 04, 2014 at 11:17:41AM +0100, Cyril Hrubis wrote:
> Hi!
> > Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
> > ---
> >  testcases/kernel/syscalls/getgroups/getgroups01.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/testcases/kernel/syscalls/getgroups/getgroups01.c b/testcases/kernel/syscalls/getgroups/getgroups01.c
> > index 9fb4c98..28559d3 100644
> > --- a/testcases/kernel/syscalls/getgroups/getgroups01.c
> > +++ b/testcases/kernel/syscalls/getgroups/getgroups01.c
> > @@ -74,8 +74,6 @@ int main(int ac, char **av)
> >  	int i;
> >  	int entries;
> >  
> > -	initgroups("root", 0);
> > -
> >  	if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
> >  		tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
> >  
> > @@ -183,6 +181,9 @@ static void setup(void)
> >  	tst_sig(FORK, DEF_HANDLER, cleanup);
> >  
> >  	TEST_PAUSE;
> > +
> > +	GID_T init_gidset[3] = {0, 1, 2};
> 
> This should be gid_t instead of GID_T. The uppercase prototypes are for
> raw syscalls only. The setgroups() you call is glibc wrapper instead.
> 
> > +	setgroups(3, init_gidset);
> 
> Otherwise it looks good to me.

Thanks, this is the new patch for review.


From 261b475fe4ecf8572003b0c444394b67feb0c781 Mon Sep 17 00:00:00 2001
From: Han Pingtian <hanpt@linux.vnet.ibm.com>
Date: Thu, 4 Dec 2014 16:07:25 +0800
Subject: [PATCH] set supplementary groups instead of relying on system setting

On a system where root belongs to only one group, the 3# test of
getgroups01 will fail by TCONF. But if we call setgroups() to set
supplementary groups, the test can succeed if run as privileged user.

With this patch, it'll still fail by TCONF when being run by
unprivileged user.

Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
---
 testcases/kernel/syscalls/getgroups/getgroups01.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/testcases/kernel/syscalls/getgroups/getgroups01.c b/testcases/kernel/syscalls/getgroups/getgroups01.c
index 9fb4c98..02c8ce0 100644
--- a/testcases/kernel/syscalls/getgroups/getgroups01.c
+++ b/testcases/kernel/syscalls/getgroups/getgroups01.c
@@ -74,8 +74,6 @@ int main(int ac, char **av)
 	int i;
 	int entries;
 
-	initgroups("root", 0);
-
 	if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
 		tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
 
@@ -183,6 +181,9 @@ static void setup(void)
 	tst_sig(FORK, DEF_HANDLER, cleanup);
 
 	TEST_PAUSE;
+
+	git_t init_gidset[3] = {0, 1, 2};
+	setgroups(3, init_gidset);
 }
 
 static void cleanup(void)
-- 
1.9.3


------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list