From: Cyril Hrubis <chrubis@suse.cz>
To: Zeng Linggang <zenglg.jy@cn.fujitsu.com>
Cc: ltp-list <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH] test.sh: tst_resm and tst_brkm enhance
Date: Mon, 8 Dec 2014 14:00:45 +0100 [thread overview]
Message-ID: <20141208130045.GA13319@rei.suse.de> (raw)
In-Reply-To: <1418042315.13292.4.camel@G08JYZSD130126.localdomain>
Hi!
> In <LTP>/testcases/network/multicast/mc_cmds
> --------------------------------------------------------------------------------
> ...
> 113 ping -c2 -I $INTERFACE 224.0.0.1 > $PING_OUT
> 114 if [ $? -ne 0 ]; then
> 115 tst_resm TINFO "Trying to ping with $INTERFACE_DEVICE"\
> 116 "with the -I option instead of IP address"
> ...
> 122 fi
> ...
> --------------------------------------------------------------------------------
>
> If "ping -c2 -I $INTERFACE 224.0.0.1 > $PING_OUT" failed,
> it just output "Trying to ping with $INTERFACE_DEVICE",
> "with the -I option instead of IP address" would be discard.
>
> After this patch, if "ping ..." failed the second string also output.
Good catch. Can you please send a patch that includes this information
in the description as well?
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2014-12-08 13:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-06 8:53 [LTP] [PATCH] test.sh: tst_resm and tst_brkm enhance Zeng Linggang
2014-12-08 11:35 ` Cyril Hrubis
[not found] ` <1418042315.13292.4.camel@G08JYZSD130126.localdomain>
2014-12-08 13:00 ` Cyril Hrubis [this message]
[not found] ` <1418087559.13292.5.camel@G08JYZSD130126.localdomain>
2014-12-09 12:02 ` [LTP] [PATCH v2] " Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141208130045.GA13319@rei.suse.de \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=zenglg.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox