From: Cyril Hrubis <chrubis@suse.cz>
To: xuw@redhat.com
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCHv3] library: add tst_system for wrapper system(3) without SIGCHLD
Date: Tue, 16 Dec 2014 15:54:48 +0100 [thread overview]
Message-ID: <20141216145448.GA19489@rei> (raw)
In-Reply-To: <1418739938-2123-1-git-send-email-xuw@redhat.com>
Hi!
> - if (system("mkfs.btrfs 2>&1 | grep '\\-f ' >/dev/null") == 0) {
> + if (0 == tst_system(
> + "mkfs.btrfs 2>&1 | grep '\\-f ' >/dev/null")
> + ) {
This is way too ugly. What about:
if (!tst_system("mkfs.btrfs 2>&1 | grep '\\-f '>/dev/null")) {
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2014-12-16 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 14:25 [LTP] [PATCHv3] library: add tst_system for wrapper system(3) without SIGCHLD xuw
2014-12-16 14:54 ` Cyril Hrubis [this message]
[not found] ` <489454473.16387266.1418795067082.JavaMail.zimbra@redhat.com>
2014-12-17 12:33 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141216145448.GA19489@rei \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=xuw@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox