Re: [LTP] [PATCHv3] library: add tst_system for wrapper system(3) without SIGCHLD

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> -       if (system("mkfs.btrfs 2>&1 | grep '\\-f ' >/dev/null") == 0) {
> here is the original author's check, use "== 0", so I'am not sure the "!tst_system" will be good for ltp's coding style.
> 
> and if I make codes like this, the next line's style will not be consistent to it:
> +       if (!tst_system("mkfs.btrfs 2>&1 | grep '\\-f ' >/dev/null")) {
>             tst_resm(TINFO, "Appending '-f' flag to mkfs.%s", 
>                 fs_type);

I do not get what is inconsistent here. The line for the if condition is
79 chars long that way, the next line with tst_resm would be more than
80 therefore it should continue on the next line. It's that simple.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list