Re: [LTP] recvfrom01: fix test for invalid message flags

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> > Note that this introduces a failure on kernels before 3.17, which has
> > a bug fix for MSG_ERRQUEUE flag handling. This failure is a legitimate
> > bug on these older kernels. (They should not be returning success with
> > no data available.)
> 
> I hit a failure in this testcase while trying latest LTP before release.
> Are you sure this is a bug?
> 
> Looking at commit history and man-pages, this looks more like new feature to me,
> flag that has not been supported before and now it is.
> 
> "MSG_ERRQUEUE is illegal on SOCK_STREAM sockets." [1]
> "TCP timestamping introduced MSG_ERRQUEUE handling for TCP sockets." [2][3]
> 
> Until commit [3], tcp_recvmsg() has ignored this flag and it was also documented
> that way. So, I don't see why TFAIL is valid result on <3.17 for MSG_ERRQUEUE test:

I think that there is no harm in disabling that case for kernels prior 3.17.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list