Re: [LTP] [PATCH] runltp: export initialized LTP_DEV

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> > This patch restores behavior from ltp-20140828, where LTP_DEV is exported
> > and tst_acquire_device() will use that instead of trying to acquire/release
> > loopdev on its own.
> 
> That wouldn't do because that breaks the exectuion when device was not
> passed to runltp. What about exporting it but only when it's non-empty?

To explain it better. That breaks execution on systems that has no
support for loop devices (not compiled in kernel), because the function
to prepare loop devices fails and LTP_DEV ends up exported as empty
string.

The library then pickups the empty string and tries to format it with
mkfs.

Looking at the code now, the code seems to be prepared for that option
the LTP_DEV should have been exported only if the create_block() function
was sucessfull but the code does apparently does not work for the case
above.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list