Re: [LTP] [PATCH] runltp: export initialized LTP_DEV

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> This patch restores behavior from ltp-20140828, where LTP_DEV is exported
> and tst_acquire_device() will use that instead of trying to acquire/release
> loopdev on its own.

Sorry for my confusion. This patch is correct as it moves the export to
the right places. I didn't read till it carefully and thought this
simply reverts the change, sorry.

The change is acked, but I think that it merely avoids the EBUSY from
the ioctl() and that there is a real bug somewhere, likely some race
condition in kernel.

> Signed-off-by: Jan Stancek <jstancek@redhat.com>
> ---
>  runltp |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/runltp b/runltp
> index e803898..8116306 100755
> --- a/runltp
> +++ b/runltp
> @@ -1011,10 +1011,10 @@ set_block_device()
>              echo "Tests which require block device are disabled."
>              echo "You can specify it with option -b"
>  	else
> -            LTP_DEV=$DEVICE
> +            export LTP_DEV=$DEVICE
>          fi
>      else
> -        LTP_DEV=$DEVICE
> +        export LTP_DEV=$DEVICE
>      fi
>  }
>  
> -- 
> 1.7.1
> 

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list