public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Han Pingtian <hanpt@linux.vnet.ibm.com>
To: ltp-list@lists.sourceforge.net
Subject: [LTP] [PATCH] increasing buffer size for correct alignment
Date: Mon, 26 Jan 2015 17:46:13 +0800	[thread overview]
Message-ID: <20150126094613.GA2055@localhost.localdomain> (raw)

Hey there,

I have a patch for aio-stress to align buffer address correctly. Please
have a look. Thanks in advance.

For align buffer address to the number specified by -a option in
aio-stress, it needs to add page_size_mask extra length to total_ram
before call allocation functions. Or it wouldn't be correct in this line
after the allocation:

         p = (char *)((intptr_t) (p + page_size_mask) & ~page_size_mask);

Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
---
 testcases/kernel/io/ltp-aiodio/aio-stress.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/testcases/kernel/io/ltp-aiodio/aio-stress.c b/testcases/kernel/io/ltp-aiodio/aio-stress.c
index 0b7148c..24675ec 100644
--- a/testcases/kernel/io/ltp-aiodio/aio-stress.c
+++ b/testcases/kernel/io/ltp-aiodio/aio-stress.c
@@ -1022,7 +1022,7 @@ int setup_shared_mem(int num_threads, int num_files, int depth,
 	if (use_shm == USE_MALLOC) {
 		p = malloc(total_ram + page_size_mask);
 	} else if (use_shm == USE_SHM) {
-		shm_id = shmget(IPC_PRIVATE, total_ram, IPC_CREAT | 0700);
+		shm_id = shmget(IPC_PRIVATE, total_ram + page_size_mask, IPC_CREAT | 0700);
 		if (shm_id < 0) {
 			perror("shmget");
 			drop_shm();
@@ -1046,9 +1046,9 @@ int setup_shared_mem(int num_threads, int num_files, int depth,
 			goto free_buffers;
 		}
 		unlink(mmap_name);
-		ftruncate(fd, total_ram);
+		ftruncate(fd, total_ram + page_size_mask);
 		shm_id = fd;
-		p = mmap((char *)0x50000000, total_ram,
+		p = mmap((char *)0x50000000, total_ram + page_size_mask,
 			 PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
 
 		if (p == MAP_FAILED) {
-- 
1.9.3


------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

             reply	other threads:[~2015-01-26 10:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26  9:46 Han Pingtian [this message]
2015-01-26 13:45 ` [LTP] [PATCH] increasing buffer size for correct alignment Cyril Hrubis
2015-01-27  1:31   ` Han Pingtian
2015-01-28 12:10     ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150126094613.GA2055@localhost.localdomain \
    --to=hanpt@linux.vnet.ibm.com \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox