Re: [LTP] [RESEND PATCH v3 4/4] syscall/{rename11, renameat01}: do not test EMLINK if subdir limit not availiable

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> > Or is there really reason why we need to differentiate between these two
> > conditions?
> This is also what I'm a little confused. Use different return values, I just
> think we should distinguish different situations. If it returns -1 (or some
> other appropriate values), then we can just skip the test, and this is why
> I passed TPASS to tst_resm() in v2. If it returns 0, which means the fs has
> the limit, but we cannot reach it, something may go wrong (or be changed).

The TCONF flag means "test is not appropriate for current configuration"
which is the case in both cases.

I simply do not see a difference between the case where we know that the
filesystem has no limit and skip the test and the case where we try and
find out that the filesystem has no limit. So I just argue that the
return value for both cases should be 0 because it does not much sense
to distinguish these two in the actuall test.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list