Re: [LTP] network namespaces tests cleanup

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> Alternatively, you could approach it a bit differently - test the
> actual kernel namespacing functionality using unshare/setns in
> *kernel*/containers/ and verify that iproute2 uses it in
> network/iproute/ (or perhaps commands/ip/ ?).

Right what needs to be tested is the kernel functionality and that the
tools call correct syscall with correct paramters, these are two
different things. But still as far as I can see the easiest way is to
run the whole test and switch between the tool it uses which is just a
few lines of code.

How do you plan to test that ip does what it should? Run it under strace
and grep for the syscall and check the parameters? That sound fragile to
me. Or is there a better way?

> The idea being that you don't exactly need to "brute force" test
> everything everytime - the kernel functionality doesn't change
> based on what utility uses the unshare() syscall.
> I (in ltp-unrelated activities) found out that this approach gives
> the best coverage / time / maintenance ratio.

Agree that the kernel functionality is the same. But how does having two
different testcases one for kernel functionality and one for ip decrease
maintenance ratio? This soulution would IMHO be more complicated. The
coverate should be same. The only aspect in which this solution is
likely better is test runtime, but that shouldn't be a problem because
these testcases does not take long time. Or am I mistaken?

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list