From: Cyril Hrubis <chrubis@suse.cz>
To: "gux.fnst" <gux.fnst@cn.fujitsu.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v2 5/6] power_management: cleanup
Date: Tue, 24 Feb 2015 10:44:55 +0100 [thread overview]
Message-ID: <20150224094455.GB32083@rei> (raw)
In-Reply-To: <54DC3853.7030203@cn.fujitsu.com>
Hi!
> >> -$sched_mc & sched_smt=$sched_smt"
> >> + echo "${FAIL}: cpu consolidation passed for" \
> >> + "sched_mc=$sched_mc & sched_smt=$sched_smt"
> >> fi
> >> ;;
> >> *)
> >> if [ $pass_count -lt 5 ]; then
> >> - tst_resm TFAIL "cpu consolidation for sched_mc=\
> >> -$sched_mc & sched_smt=$sched_smt"
> >> - else
> >> RC=1
> >> - tst_resm TPASS "cpu consolidation for sched_mc=\
> >> -$sched_mc & sched_smt=$sched_smt"
> >> + echo "${FAIL}: cpu consolidation for" \
> >> + "sched_mc=$sched_mc & sched_smt=$sched_smt"
> >> + else
> >> + echo "${PASS}: cpu consolidation for" \
> >> + "sched_mc=$sched_mc & sched_smt=$sched_smt"
> >
> > I do not get how removing tst_resm and changing it to echo satisfies
> > "Use functions in test.sh, eg. tst_brkm" from the commit log.
>
> This is a subset of each test case, eg. runpwtests_exclusive01.sh. Here if we use
> tst_resm TPASS/TFAIL, it results in a mismatch between the count of TPASS/TFAIL and
> the TST_COUNT in each case. So I change "tst_resm" to "echo".
> I don't have a better way to do this. Could you give me some hints about it? Thanks!
If these are separable testcases the best would be to split them into
testcases. If they are not, we can always fix the TST_COUNT to match the
reality...
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2015-02-24 9:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 8:41 [LTP] [PATCH v2 1/6] lib/sched_mc.py: fix path for ebizzy/kernbench benchmark Xing Gu
2015-02-06 8:41 ` [LTP] [PATCH v2 2/6] power_management: compile and install testcases/kernel/power_management by default Xing Gu
2015-02-09 14:10 ` Cyril Hrubis
2015-02-06 8:41 ` [LTP] [PATCH v2 3/6] power_management: install lib/sched_mc.py into testcases/bin directory Xing Gu
2015-02-09 14:17 ` Cyril Hrubis
[not found] ` <54DC3837.8050300@cn.fujitsu.com>
2015-02-24 9:36 ` Cyril Hrubis
2015-02-06 8:41 ` [LTP] [PATCH v2 4/6] power_management: add uclinux check and move some check Xing Gu
2015-02-09 14:19 ` Cyril Hrubis
2015-02-09 14:22 ` Cyril Hrubis
2015-02-06 8:41 ` [LTP] [PATCH v2 5/6] power_management: cleanup Xing Gu
2015-02-09 14:39 ` Cyril Hrubis
[not found] ` <54DC3853.7030203@cn.fujitsu.com>
2015-02-24 9:44 ` Cyril Hrubis [this message]
2015-02-06 8:41 ` [LTP] [PATCH v2 6/6] power_management: add it into default Xing Gu
2015-02-09 14:49 ` [LTP] [PATCH v2 1/6] lib/sched_mc.py: fix path for ebizzy/kernbench benchmark Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150224094455.GB32083@rei \
--to=chrubis@suse.cz \
--cc=gux.fnst@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox