Re: [LTP] [PATCH 1/3] device-drivers/locking: add wrapper for locktorture kernel module

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> +TCID="lock_torture"
> +TST_TOTAL=5
> +TST_CLEANUP=cleanup
> +. test.sh
> +
> +# default options
> +test_time=60
> +
> +while getopts :ht: opt; do
> +	case "$opt" in
> +	h)
> +		echo "Usage:"
> +		echo "h        help"
> +		echo "t x      time in seconds for each test-case"
> +		exit 0
> +	;;
> +	t) test_time=$OPTARG ;;
> +	*)
> +		tst_brkm TBROK "unknown option: $opt"
> +	;;
> +	esac
> +done
> +
> +cleanup()
> +{
> +	tst_resm TINFO "cleanup"
> +	rmmod locktorture > /dev/null 2>&1
> +}
> +
> +tst_kvercmp 3 18 0 && \
> +	tst_brkm TCONF "test must be run with kernel 3.18 or newer"

We check if the module is present, do we have to check for the kernel
version too?


Otherwise it look OK.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list