public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Jan Stancek <jstancek@redhat.com>
Cc: jkastner@redhat.com, ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH 1/2] sched_setparam/9-1: fix hang on -rt kernel
Date: Tue, 3 Mar 2015 15:23:35 +0100	[thread overview]
Message-ID: <20150303142335.GA22464@rei> (raw)
In-Reply-To: <951353219.21574463.1425379677968.JavaMail.zimbra@redhat.com>

Hi!
> > > I think you're right in scenario with single CPU.
> > > In theory, is it possible that set_affinity() would be dummy, and one of
> > > ncpu-1 children running with max FIFO priority would preempt parent
> > > allowing test_process() to run before its priority is changed?
> > 
> > Aren't the child proceesses forked with the same priority as the parent?
> > In this case they shouldn't get executed for the same reason unless they
> > are migrated other CPUs. But yes then it's a kind of unpredictable which
> > is the reason we have the affinity call there.
> 
> Would you prefer I rewrite that comment? Or are you OK with the patch as it is?

It would be better to make the comment more clear.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

      parent reply	other threads:[~2015-03-03 14:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-27 10:41 [LTP] [PATCH 1/2] sched_setparam/9-1: fix hang on -rt kernel Jan Stancek
2015-02-27 10:41 ` [LTP] [PATCH 2/2] sched_setparam/10-1: remove testcase Jan Stancek
2015-03-02 13:11   ` Cyril Hrubis
2015-03-02 13:04 ` [LTP] [PATCH 1/2] sched_setparam/9-1: fix hang on -rt kernel Cyril Hrubis
     [not found]   ` <1750098575.20916844.1425303360282.JavaMail.zimbra@redhat.com>
2015-03-02 13:47     ` Cyril Hrubis
     [not found]       ` <951353219.21574463.1425379677968.JavaMail.zimbra@redhat.com>
2015-03-03 14:23         ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150303142335.GA22464@rei \
    --to=chrubis@suse.cz \
    --cc=jkastner@redhat.com \
    --cc=jstancek@redhat.com \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox