public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Jan Stancek <jstancek@redhat.com>
Cc: ltp-list <ltp-list@lists.sf.net>
Subject: Re: [LTP] Coverity report for ltp-20150420
Date: Thu, 30 Apr 2015 11:03:57 +0200	[thread overview]
Message-ID: <20150430090357.GA23406@rei.suse.de> (raw)
In-Reply-To: <162165083.8714320.1430382121729.JavaMail.zimbra@redhat.com>

Hi!
> >From what I have read, it should be possible to annotate code to make coverity
> stop complaining. For example by adding following:
>   /* coverity[EVENT_TAG_NAME] */
> 
> I'm not exactly clear where to get "event tag names" yet, as these seem to be
> different from error names that appear in *.err logs.
> 
> Before I dig deeper into this, would anyone be opposed if we start adding
> such annotation to LTP source?

I'm OK with adding a few annotations to places where LTP does something
that needs to be done and what is normally a bug. As far as I remember
we have a few places that dereference NULL to cause segfault that
produce false-possitive warnings as well.

Looking at the BAD_FREE the munmap03.c is nice example of that. However
most of the BAD_FREE, if I understant it correctly, are result of
unmaping only part of the mmaped memory. That is not really bug, but I
guess that I can live with annotations for these as well if you want
them.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

      reply	other threads:[~2015-04-30  9:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1555406842.5673672.1429863249724.JavaMail.zimbra@redhat.com>
2015-04-24 13:54 ` [LTP] Coverity report for ltp-20150420 Jan Stancek
2015-04-27 13:24   ` Cyril Hrubis
     [not found]     ` <699964060.6783089.1430144771050.JavaMail.zimbra@redhat.com>
2015-04-27 15:58       ` Cyril Hrubis
     [not found]         ` <1789445018.7218822.1430210865329.JavaMail.zimbra@redhat.com>
2015-04-28  9:47           ` Cyril Hrubis
2015-04-30  8:22   ` Jan Stancek
2015-04-30  9:03     ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150430090357.GA23406@rei.suse.de \
    --to=chrubis@suse.cz \
    --cc=jstancek@redhat.com \
    --cc=ltp-list@lists.sf.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox