[LTP] [PATCH 1/5] README: fix typos and remove blank lines

[LTP] [PATCH 1/5] README: fix typos and remove blank lines

[Wei,Jiangang]

The location of README,
open_posix_testsuite/conformance/interfaces/sigaction/README

Signed-off-by: Wei,Jiangang <weijg.fnst@cn.fujitsu.com>
---
 .../open_posix_testsuite/conformance/interfaces/sigaction/README    | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/testcases/open_posix_testsuite/conformance/interfaces/sigaction/README b/testcases/open_posix_testsuite/conformance/interfaces/sigaction/README
index 62ddec3..06ce6c6 100644
--- a/testcases/open_posix_testsuite/conformance/interfaces/sigaction/README
+++ b/testcases/open_posix_testsuite/conformance/interfaces/sigaction/README
@@ -1,5 +1,5 @@
-<< First, an explaination for the perl script and the stuff >>
-<< in the template directoy                                 >>
+<< First, an explanation for the perl script and the stuff >>
+<< in the template directory                               >>
 
 I have added a cheezy perl script for generating a bunch of test cases
 where I want to do the same simple operation on each signal.
@@ -16,5 +16,3 @@ with the signal name.
 * Assertion #5: Since almost all of the test cases in this directory assume
                 that this assertion is true, I haven't bothered adding
                 a test case that just test assertion #5.
-
-
-- 
1.9.3


------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 2/5] kernel/fs/doio/growfiles: add parameter for printf

[Wei,Jiangang]

printf format string requires 1 parameter but only 0 are given.

Signed-off-by: Wei,Jiangang <weijg.fnst@cn.fujitsu.com>
---
 testcases/kernel/fs/doio/growfiles.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/kernel/fs/doio/growfiles.c b/testcases/kernel/fs/doio/growfiles.c
index a656978..09e7f35 100644
--- a/testcases/kernel/fs/doio/growfiles.c
+++ b/testcases/kernel/fs/doio/growfiles.c
@@ -677,7 +677,7 @@ int main(int argc, char **argv)
 				exit(1);
 			}
 			Upanic_on_error++;
-			printf("%s: Will call upanic after writes\n");
+			printf("%s%s: Will call upanic after writes\n", Progname, TagName);
 #else
 			printf
 			    ("%s%s: --P is illegal option on non-cray system\n",
-- 
1.9.3


------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 2/5] kernel/fs/doio/growfiles: add parameter for printf

[Cyril Hrubis]

Hi!
> printf format string requires 1 parameter but only 0 are given.

Applied, however we do not support CRAY anymore, so the code between
#ifdef CRAY could have been removed as well.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 3/5] hugemmap/hugemmap05: fix resource leak

[Wei,Jiangang]

ensure close FILE pointer before return

Signed-off-by: Wei,Jiangang <weijg.fnst@cn.fujitsu.com>
---
 testcases/kernel/mem/hugetlb/hugemmap/hugemmap05.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap05.c b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap05.c
index 97d7689..8b9a05f 100644
--- a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap05.c
+++ b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap05.c
@@ -439,6 +439,7 @@ static int checksys(char *path, char *string, int value)
 	if (atoi(buf) != value) {
 		tst_resm(TFAIL, "%s is not %d but %d.", string, value,
 			 atoi(buf));
+		fclose(fp);
 		return 1;
 	}
 	fclose(fp);
@@ -474,6 +475,7 @@ static void init_hugepagesize(void)
 		if (lookup(line, "Hugepagesize")) {
 			tst_resm(TINFO, "Hugepagesize is %s kB", buf);
 			hugepagesize = atoi(buf) * 1024;
+			fclose(fp);
 			return;
 		}
 	}
-- 
1.9.3


------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 3/5] hugemmap/hugemmap05: fix resource leak

[Cyril Hrubis]

Hi!
> ensure close FILE pointer before return
> 
> Signed-off-by: Wei,Jiangang <weijg.fnst@cn.fujitsu.com>
> ---
>  testcases/kernel/mem/hugetlb/hugemmap/hugemmap05.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap05.c b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap05.c
> index 97d7689..8b9a05f 100644
> --- a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap05.c
> +++ b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap05.c
> @@ -439,6 +439,7 @@ static int checksys(char *path, char *string, int value)
>  	if (atoi(buf) != value) {
>  		tst_resm(TFAIL, "%s is not %d but %d.", string, value,
>  			 atoi(buf));
> +		fclose(fp);
>  		return 1;
>  	}
>  	fclose(fp);
> @@ -474,6 +475,7 @@ static void init_hugepagesize(void)
>  		if (lookup(line, "Hugepagesize")) {
>  			tst_resm(TINFO, "Hugepagesize is %s kB", buf);
>  			hugepagesize = atoi(buf) * 1024;
> +			fclose(fp);
>  			return;
>  		}
>  	}

Applied, thanks.

Hint: These function can be replaced with SAFE_FILE_SCANF() and
      one comparsion.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 4/5] cpuset_cpu_hog: fix memory leak

[Wei,Jiangang]

Signed-off-by: Wei,Jiangang <weijg.fnst@cn.fujitsu.com>
---
 .../kernel/controllers/cpuset/cpuset_load_balance_test/cpuset_cpu_hog.c  | 1 +
 1 file changed, 1 insertion(+)

diff --git a/testcases/kernel/controllers/cpuset/cpuset_load_balance_test/cpuset_cpu_hog.c b/testcases/kernel/controllers/cpuset/cpuset_load_balance_test/cpuset_cpu_hog.c
index 7f96d3c..de81f26 100644
--- a/testcases/kernel/controllers/cpuset/cpuset_load_balance_test/cpuset_cpu_hog.c
+++ b/testcases/kernel/controllers/cpuset/cpuset_load_balance_test/cpuset_cpu_hog.c
@@ -316,6 +316,7 @@ int main(int argc, char **argv)
 			ret = EXIT_FAILURE;
 	}
 
+	free(childpids);
 	return ret;
 }
 
-- 
1.9.3


------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 5/5] network/sockets/ltpClient: close fd to avoid leak

[Wei,Jiangang]

Signed-off-by: Wei,Jiangang <weijg.fnst@cn.fujitsu.com>
---
 testcases/network/sockets/ltpClient.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/testcases/network/sockets/ltpClient.c b/testcases/network/sockets/ltpClient.c
index b4754a3..2981737 100644
--- a/testcases/network/sockets/ltpClient.c
+++ b/testcases/network/sockets/ltpClient.c
@@ -401,6 +401,7 @@ int network_listener(char *hostName, int pid)
 		}
 	}
 
+	close(rawSocket);
 	return (0);
 }
 
@@ -547,6 +548,8 @@ void ping_network(struct sockaddr_in *rawAddr, int pid)
 			break;
 		}
 	}
+
+	close(rawSocket);
 }
 
 /**********************************************************************
-- 
1.9.3


------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 5/5] network/sockets/ltpClient: close fd to avoid leak

[Cyril Hrubis]

Hi!
And the rest is applied as well, thanks.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list