From: Cyril Hrubis <chrubis@suse.cz>
To: "Wei, Jiangang" <weijg.fnst@cn.fujitsu.com>
Cc: "ltp-list@lists.sourceforge.net" <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH 3/3] kernel/mem/mmapstress: fix resource leak
Date: Tue, 12 May 2015 11:12:35 +0200 [thread overview]
Message-ID: <20150512091235.GA3562@rei.suse.de> (raw)
In-Reply-To: <1431067342.1760.10.camel@localhost>
Hi!
> There's no cleanup function for SAFE_CLOSE(). so,
> close() is the same as SAFE_CLOSE(NULL, fd).
FYI, there is a difference between plain close() and
SAFE_CLOSE(NULL, fd). The latter checks the return value
from close(). Have a look at lib/safe_macros.c.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2015-05-12 9:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 10:18 [LTP] [PATCH 1/3] kernel/syscalls/fallocate: fix array parameter degradation Wei,Jiangang
2015-05-06 10:18 ` [LTP] [PATCH 2/3] kernel/syscalls/fallocate: specify size needs check Wei,Jiangang
2015-05-06 20:42 ` Alexey Kodanev
2015-05-07 4:53 ` Wei, Jiangang
2015-05-07 6:17 ` [LTP] [PATCH v2] kernel/syscalls/fallocate: fix array parameter degradation Wei,Jiangang
2015-05-07 9:37 ` Alexey Kodanev
2015-05-07 9:54 ` Wei, Jiangang
2015-05-12 5:43 ` Wanlong Gao
2015-05-12 5:44 ` Wanlong Gao
2015-05-12 5:52 ` Wei, Jiangang
2015-05-06 10:18 ` [LTP] [PATCH 3/3] kernel/mem/mmapstress: fix resource leak Wei,Jiangang
2015-05-07 14:05 ` Alexey Kodanev
2015-05-08 6:42 ` Wei, Jiangang
2015-05-12 9:12 ` Cyril Hrubis [this message]
2015-05-13 12:03 ` Alexey Kodanev
2015-05-08 6:47 ` [LTP] [PATCH v2] " Wei,Jiangang
2015-05-19 3:34 ` [LTP] [PATCH] mmapstress01: Modify readbuf's type and define it to uchar_t Zeng Linggang
2015-05-19 9:23 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150512091235.GA3562@rei.suse.de \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=weijg.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox