[LTP] test_fs_bind.sh testcase fails to clean up files which it had created during the first run

[LTP] test_fs_bind.sh testcase fails to clean up files which it had created during the first run

[ramya]

From: ramya BS <ramya@linux.vnet.ibm.com>

Description:
when we run the script for the first time, all the test will run successfully and PASS .
but on the same machine if we run the same script for the 2nd time we see TBROK .

TBROK was seen because the script was not cleaning the files it created during the first run.
so added TWARN "did not properly clean up files" and then removing the files and continuing with the test .

Signed-off-by: ramya BS <ramya@linux.vnet.ibm.com>
---
 testscripts/test_fs_bind.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/testscripts/test_fs_bind.sh b/testscripts/test_fs_bind.sh
index 792fff2..348f320 100755
--- a/testscripts/test_fs_bind.sh
+++ b/testscripts/test_fs_bind.sh
@@ -343,8 +343,8 @@ save_sandbox()
 
 	if [ -e "$2/files.before" ]; then
 		if [ -e "$2/files.after" ]; then
-			tst_brkm TBROK true "${tname}: stale catalog of \"${sandbox}\""
-			return 1
+			tst_resm TWARN true "${tname}: did not properly clean up files"
+                        rm -f "$2/files.after" 
 		fi
 		when="after"
 	fi
-- 
1.7.1


------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] test_fs_bind.sh testcase fails to clean up files which it had created during the first run

[Cyril Hrubis]

Hi!
> Description:
> when we run the script for the first time, all the test will run successfully and PASS .
> but on the same machine if we run the same script for the 2nd time we see TBROK .
> 
> TBROK was seen because the script was not cleaning the files it created during the first run.
> so added TWARN "did not properly clean up files" and then removing the files and continuing with the test .
> 
> Signed-off-by: ramya BS <ramya@linux.vnet.ibm.com>
> ---
>  testscripts/test_fs_bind.sh |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/testscripts/test_fs_bind.sh b/testscripts/test_fs_bind.sh
> index 792fff2..348f320 100755
> --- a/testscripts/test_fs_bind.sh
> +++ b/testscripts/test_fs_bind.sh
> @@ -343,8 +343,8 @@ save_sandbox()
>  
>  	if [ -e "$2/files.before" ]; then
>  		if [ -e "$2/files.after" ]; then
> -			tst_brkm TBROK true "${tname}: stale catalog of \"${sandbox}\""
> -			return 1
> +			tst_resm TWARN true "${tname}: did not properly clean up files"
> +                        rm -f "$2/files.after" 

The second line is indented by spaces while the rest of the file uses
tabs, be consistent and use tabs as well. It also ends with trailing
whitespace, which should be removed.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] test_fs_bind.sh testcase fails to clean up files which it had created during the first run

[ramya]

From: Ramya BS <ramya@linux.vnet.ibm.com>

Description:
when we run the script for the first time, all the test will run successfully and PASS .
but on the same machine if we run the same script for the 2nd time we see TBROK .

TBROK was seen because the script was not cleaning the files it created during the first run.
so added TWARN "did not properly clean up files" and then removing the files and continuing with the test .

Signed-off-by: Ramya BS <ramya@linux.vnet.ibm.com>
---
 testscripts/test_fs_bind.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/testscripts/test_fs_bind.sh b/testscripts/test_fs_bind.sh
index 792fff2..b6cb58f 100755
--- a/testscripts/test_fs_bind.sh
+++ b/testscripts/test_fs_bind.sh
@@ -343,8 +343,8 @@ save_sandbox()
 
 	if [ -e "$2/files.before" ]; then
 		if [ -e "$2/files.after" ]; then
-			tst_brkm TBROK true "${tname}: stale catalog of \"${sandbox}\""
-			return 1
+			tst_resm TWARN true "${tname}: did not properly clean up files"
+			rm -f "$2/files.after" 
 		fi
 		when="after"
 	fi
-- 
1.7.1




Thanks&Regards,
Ramya BS


------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list