public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Cui Bixuan <cuibixuan@huawei.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] performing test on loop device if noatime or relatime specified
Date: Tue, 12 May 2015 15:48:59 +0200	[thread overview]
Message-ID: <20150512134858.GA11906@rei.suse.de> (raw)
In-Reply-To: <5551F71E.7090400@huawei.com>

Hi!
> then compile error:
> gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall -W -g -O2 -Wold-style-definition -D_FORTIFY_SOURCE=2 -I/home/cuibixuan/home/git/ltp/ltp/testcases/kernel/include -I../../../../include -I../../../../include   -L../../../../lib  open12.c   -lltp -o open12
> open12.c: In function ?setup?:
> open12.c:103: error: ?MS_STRICTATIME? undeclared (first use in this function)
> open12.c:103: error: (Each undeclared identifier is reported only once
> open12.c:103: error: for each function it appears in.)
> make[4]: *** [open12] Error 1
> make[4]: Leaving directory `/home/cuibixuan/home/git/ltp/ltp/testcases/kernel/syscalls/open'
> 
> Do 'man mount' and can not find 'MS_STRICTATIME'.
> 
> I get from man-pages of linux:
> MS_STRICTATIME (since Linux 2.6.30)
>               Always update the last access time (atime) when files on this
>               filesystem are accessed.  (This was the default behavior
>               before Linux 2.6.30.)  Specifying this flag overrides the
>               effect of setting the MS_NOATIME and MS_RELATIME flags.
> 
> If not support 'MS_STRICTATIME'?
> My system is SUSE11-SP2, linux 3.0.13, and gcc version 4.3.4.

Solution to compilation failures is to add fallback definition into
ltp/include/lapi/mount.h (have a look at ltp/include/lapi/fcntl.h) and
include it in the testcase source. That would make the testcase compile,
but it may still fail when executed. To fix the execution we would need
to do a runtime check if the kernel supports this flag, I guess that we
would need to pass it only on newer kernels (we use tst_kvercmp() for
that).

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2015-05-12 13:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-04  6:34 [LTP] [PATCH] performing test on loop device if noatime or relatime specified Han Pingtian
2015-05-04 11:53 ` Cyril Hrubis
2015-05-06 13:55   ` Han Pingtian
2015-05-07 12:48     ` Cyril Hrubis
2015-05-08  1:41       ` Han Pingtian
2015-05-12 12:50     ` Cui Bixuan
2015-05-12 13:48       ` Cyril Hrubis [this message]
     [not found]         ` <55530639.2070806@huawei.com>
2015-05-13  8:14           ` Cyril Hrubis
     [not found]             ` <55559C6A.9090001@huawei.com>
2015-05-18 11:56               ` [LTP] [PATCH] open/open12: compile error Cyril Hrubis
     [not found]         ` <55530742.3030707@huawei.com>
2015-05-13  9:03           ` [LTP] [PATCH] open/open12: Check the kernel version for 'MS_STRICTATIME' Cyril Hrubis
     [not found]             ` <5555A746.4080006@huawei.com>
2015-05-18 11:52               ` Cyril Hrubis
     [not found]                 ` <5559DDD9.4090807@huawei.com>
2015-05-27 14:20                   ` [LTP] [PATCH 2/2 v2] " Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150512134858.GA11906@rei.suse.de \
    --to=chrubis@suse.cz \
    --cc=cuibixuan@huawei.com \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox