public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: "Wei,Jiangang" <weijg.fnst@cn.fujitsu.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH 4/5] testcases/kernel/fs/doio: free memory
Date: Mon, 18 May 2015 13:28:00 +0200	[thread overview]
Message-ID: <20150518112800.GB4104@rei> (raw)
In-Reply-To: <1431515986-22287-4-git-send-email-weijg.fnst@cn.fujitsu.com>

Hi!
> free the memory that allocated by malloc and strdup.

You keep fixing the code inside the CRAY #ifdefs. Cray systems are not
supported for some time anyway. It would be far easier to just remove
the unused code between the CRAY and sgi ifdefs.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2015-05-18 11:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13 11:19 [LTP] [PATCH 1/5] lib/safe_file_ops: fix typo Wei,Jiangang
2015-05-13 11:19 ` [LTP] [PATCH 2/5] testcases/kernel/syscalls/fcntl: use TERRNO flag Wei,Jiangang
2015-05-18 11:40   ` Cyril Hrubis
2015-05-13 11:19 ` [LTP] [PATCH 3/5] testcases/kernel: replace umount() with tst_umount() Wei,Jiangang
2015-05-13 11:19 ` [LTP] [PATCH 4/5] testcases/kernel/fs/doio: free memory Wei,Jiangang
2015-05-18 11:28   ` Cyril Hrubis [this message]
2015-05-13 11:19 ` [LTP] [PATCH 5/5] network/nfs/nfsstress: fix printf format Wei,Jiangang
2015-05-18 11:45 ` [LTP] [PATCH 1/5] lib/safe_file_ops: fix typo Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150518112800.GB4104@rei \
    --to=chrubis@suse.cz \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=weijg.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox