Re: [LTP] [PATCH] open/open12: compile error

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> The 'MS_STRICTATIME' flag is not defined in old kernel.Now add
                                                  ^
						  libc

The system headers are supplied by glibc.

> it into include/lapi/mount.h and include it in testcase source.
> 
> Signed-off-by: Cui Bixuan <cuibixuan@huawei.com>
> ---
> Cat /usr/include/x86_64-linux-gnu/sys/mount.h in Ubuntu14 and find
> 'MS_STRICTATIME' flag:
> MS_STRICTATIME = 1 << 24,     /* Always perform atime updates.  */
> 
> So add it into include/lapi/mount.h
> And thank you for your advice,My idea is wrong.
> 
>  include/lapi/mount.h                    |   26 ++++++++++++++++++++++++++
>  testcases/kernel/syscalls/open/open12.c |    1 +
>  2 files changed, 27 insertions(+), 0 deletions(-)
>  create mode 100644 include/lapi/mount.h
> 
> diff --git a/include/lapi/mount.h b/include/lapi/mount.h
> new file mode 100644
> index 0000000..c71a638
> --- /dev/null
> +++ b/include/lapi/mount.h
> @@ -0,0 +1,26 @@
> +/*
> + * Copyright (c) 2014 Cyril Hrubis <chrubis@suse.cz>

              ^
	      Should be your name and current year. :)

> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it would be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write the Free Software Foundation,
> + * Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
> + */
> +
> +#ifndef __MOUNT_H__
> +#define __MOUNT_H__
> +
> +#ifndef MS_STRICTATIME
> +#define MS_STRICTATIME  1 << 24
> +#endif
> +
> +#endif /* __MOUNT_H__ */
> diff --git a/testcases/kernel/syscalls/open/open12.c b/testcases/kernel/syscalls/open/open12.c
> index e665368..af3fab3 100644
> --- a/testcases/kernel/syscalls/open/open12.c
> +++ b/testcases/kernel/syscalls/open/open12.c
> @@ -31,6 +31,7 @@
>  #include "test.h"
>  #include "safe_macros.h"
>  #include "lapi/fcntl.h"
> +#include "lapi/mount.h"
> 
>  #define MNTPOINT	"mntpoint"
>  #define TEST_FILE	MNTPOINT"/test_file"
> -- 
> 1.6.0.2

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list