Re: [LTP] [PATCH v2 1/2] test.sh: Add tst_acquire_device() and tst_release_device()

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> Add two functions tst_acquire_device() and tst_release_device()
> 
> Signed-off-by: Zhang Jin <jy_zhangjin@cn.fujitsu.com>
> Signed-off-by: Zeng Linggang <zenglg.jy@cn.fujitsu.com>
> ---
>  testcases/lib/test.sh | 44 ++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 44 insertions(+)
> 
> diff --git a/testcases/lib/test.sh b/testcases/lib/test.sh
> index 163c54b..3e6f742 100644
> --- a/testcases/lib/test.sh
> +++ b/testcases/lib/test.sh
> @@ -193,6 +193,50 @@ ROD()
>  	fi
>  }
>  
> +tst_acquire_device()
> +{
> +	local dd_size=$1
> +	local testdevice=$2
> +	local mntpoint=$3
> +
> +	ROD_SILENT dd if=/dev/zero of=testimg bs=1M count=${dd_size}
> +
> +	ROD_SILENT losetup ${testdevice} testimg
> +
> +	ROD_SILENT mkfs.ext2 ${testdevice}
> +
> +	ROD_SILENT mkdir -p ${mntpoint}
> +
> +	ROD_SILENT mount ${testdevice} ${mntpoint}

Hmm, I would like to keep the formatting and mounting out of the
library. Because if nothing else, user may want to use different fs than
ext2. The second reason to do so is that we may want to do exactly same
as the C function because anything else will be confusing. For that
reason the free loop device should be also queried here (and stored in a
global variable whose names starts with either tst_ or TST_).

Moreover the C function will try LTP_DEV first and if it points to a
valid block device, it will be used.

> +}
> +
> +tst_release_device()
> +{
> +	local mntpoint=$1
> +
> +	grep -q ${mntpoint} /proc/self/mounts
> +	if [ $? -eq 0 ]; then
> +		umount ${mntpoint}
> +		if [ $? -ne 0 ];then
> +			tst_resm TWARN "'umount ${mntpoint}' failed"
> +		fi
> +	fi
> +
> +	losetup -a | grep -q ${mntpoint}
> +	if [ $? -eq 0 ]; then
> +		losetup -d ${mntpoint}
> +		if [ $? -ne 0 ];then
> +			tst_resm TWARN "'losetup -d ${mntpoint}' failed"
> +		fi
> +	fi
> +
> +	if [ -d ${mntpoint} ]; then
> +		rm -r ${mntpoint}
> +	fi
> +
> +	rm testimg
> +}
> +
>  # Check that test name is set
>  if [ -z "$TCID" ]; then
>  	tst_brkm TBROK "TCID is not defined"
> -- 
> 1.9.3
> 

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list