From: Cyril Hrubis <chrubis@suse.cz>
To: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
Cc: vasily.isaenko@oracle.com, ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [RFC PATCH] tst_checkpoint_destroy
Date: Mon, 25 May 2015 10:51:28 +0200 [thread overview]
Message-ID: <20150525085128.GA2586@rei.suse.de> (raw)
In-Reply-To: <1432541376-15153-1-git-send-email-stanislav.kholmanskikh@oracle.com>
Hi!
> As of now, if we run test cases which use the tst_checkpoint framework on NFS,
> they will fail with errors like:
>
> creat07 0 TWARN : tst_tmpdir.c:206: tst_rmdir: rmobj(/tmpdir/ltp-0IVQPP0NK6/creigi0kV) failed: remove(/tmpdir/ltp-0IVQPP0NK6/creigi0kV) failed; errno=66: Directory not empty
>
> This happens because we keep the futex page mapped while tst_rmdir() is running.
>
> So on we need to unmap the page before tst_rmdir().
>
> What do you think about the proposed solution?
Why don't we hide this from user and unmap() the file in the tst_rmdir()
if checkpoint was initialized?
Otherwise I'm all for this fix.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2015-05-25 8:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 8:09 [LTP] [RFC PATCH] tst_checkpoint_destroy Stanislav Kholmanskikh
2015-05-25 8:51 ` Cyril Hrubis [this message]
[not found] ` <55642D9D.6050707@oracle.com>
2015-05-26 8:40 ` Cyril Hrubis
2015-05-26 9:16 ` [LTP] [PATCH 1/2] Move futex_t into a common header Stanislav Kholmanskikh
2015-05-26 9:16 ` [LTP] [PATCH 2/2] Unmap the futexes backend file in tst_rmdir Stanislav Kholmanskikh
2015-05-26 9:58 ` Cyril Hrubis
2015-05-26 10:21 ` [LTP] [PATCH V2 " Stanislav Kholmanskikh
2015-05-27 14:04 ` Stanislav Kholmanskikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150525085128.GA2586@rei.suse.de \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=stanislav.kholmanskikh@oracle.com \
--cc=vasily.isaenko@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox