Re: [LTP] [PATCH 2/2] Unmap the futexes backend file in tst_rmdir

[Cyril Hrubis <chrubis@suse.cz>]

Hi!
> As of now, test cases utilizing tst_checkpoint framework fail on NFS
> with similar errors:
> 
> creat07     0  TWARN  :  tst_tmpdir.c:206: tst_rmdir: rmobj(/tmpdir/ltp-0IVQPP0NK6/creigi0kV) failed: remove(/tmpdir/ltp-0IVQPP0NK6/creigi0kV) failed; errno=66: Directory not empty
> 
> This happens because we keep the futex page mapped while tst_rmdir() is running.
> 
> Let's unmap it before the actual delete procedure.
> 
> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
> ---
>  lib/tst_checkpoint.c |    2 +-
>  lib/tst_tmpdir.c     |   11 +++++++++++
>  2 files changed, 12 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/tst_checkpoint.c b/lib/tst_checkpoint.c
> index 0e2c402..36eeff2 100644
> --- a/lib/tst_checkpoint.c
> +++ b/lib/tst_checkpoint.c
> @@ -33,7 +33,7 @@
>  
>  #define DEFAULT_MSEC_TIMEOUT 10000
>  
> -static futex_t *futexes;
> +futex_t *futexes;
>  static int page_size;

Now that futexes is a global symbol we should prefix it with tst_ to
avoid clashes with testcase defined symbols.

Otherwise it looks good.

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list