From: Cyril Hrubis <chrubis@suse.cz>
To: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
Cc: vasily.isaenko@oracle.com, ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] detach_device: Wait until the kernel frees the loop device
Date: Wed, 10 Jun 2015 12:24:14 +0200 [thread overview]
Message-ID: <20150610102414.GC31366@rei.suse.de> (raw)
In-Reply-To: <55780FC7.1090100@oracle.com>
Hi!
> Do you mean printing of TINFO/TWARN messages right in the cycle?
>
> if (errno != EBUSY) {
> err = errno;
> tst_resm(TWARN,
> "ioctl(%s, LOOP_CLR_FD, 0) unexpectedly failed with: %s",
> dev, tst_strerrno(err));
> }
>
>
> But in the worst case, we may end up with 40 messages generated.
>
> Or do you mean saving the last errno and printing it to the final tst_brkm?
Either one works for me.
Having 40 messages is better than none. Because you will see these only
if something went wrong.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2015-06-10 10:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1433923871-10933-1-git-send-email-stanislav.kholmanskikh@oracle.com>
2015-06-10 8:16 ` [LTP] [PATCH] detach_device: Wait until the kernel frees the loop device Stanislav Kholmanskikh
2015-06-10 10:08 ` Cyril Hrubis
[not found] ` <55780FC7.1090100@oracle.com>
2015-06-10 10:24 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150610102414.GC31366@rei.suse.de \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=stanislav.kholmanskikh@oracle.com \
--cc=vasily.isaenko@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox