From: Cyril Hrubis <chrubis@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v2] futex: regression test for take hugepages into account when generating futex_key
Date: Mon, 29 Jun 2015 16:41:59 +0200 [thread overview]
Message-ID: <20150629144159.GB24350@rei.suse.de> (raw)
In-Reply-To: <1750983670.20645133.1435571726272.JavaMail.zimbra@redhat.com>
Hi!
> Ping~
> Any comments?
Sorry for the delay. Looks good, but the race codintion with the
semaphores is still possible, although unlikely.
Because the semaphore is posted before the second thread is locked on
the futex, there is slight possibility that the futex_wake() (from the
main thread) is called before the second thread sleeps in the futex
which will cause the testcase to fail.
I will isolate the function to assert that threads are sleeping in
kernel from the futex testcase and change this test to make use of it
and commit it.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Monitor 25 network devices or servers for free with OpManager!
OpManager is web-based network management software that monitors
network devices and physical & virtual servers, alerts via email & sms
for fault. Monitor 25 devices for free with no restriction. Download now
http://ad.doubleclick.net/ddm/clk/292181274;119417398;o
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2015-06-29 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 6:48 [LTP] [PATCH v2] futex: regression test for take hugepages into account when generating futex_key Li Wang
2015-06-29 9:55 ` Li Wang
2015-06-29 14:41 ` Cyril Hrubis [this message]
2015-06-29 16:27 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150629144159.GB24350@rei.suse.de \
--to=chrubis@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox