From: Cyril Hrubis <chrubis@suse.cz>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: ltp-list@lists.sourceforge.net, pankaj.m@samsung.com
Subject: Re: [LTP] [PATCH 2/2] open_posix/shm_unlink: sanity checking after calling pathconf
Date: Wed, 5 Aug 2015 14:59:04 +0200 [thread overview]
Message-ID: <20150805125903.GD31234@rei.suse.de> (raw)
In-Reply-To: <1436420037-18441-1-git-send-email-maninder1.s@samsung.com>
Hi!
> sanity checking after calling pathconf added
>
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Reviewed-by: Yogesh Narayan Gaur <yn.gaur@samsung.com>
> ---
> .../conformance/interfaces/shm_unlink/10-1.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/shm_unlink/10-1.c b/testcases/open_posix_testsuite/conformance/interfaces/shm_unlink/10-1.c
> index 768863c..20e5bef 100644
> --- a/testcases/open_posix_testsuite/conformance/interfaces/shm_unlink/10-1.c
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/shm_unlink/10-1.c
> @@ -27,6 +27,11 @@ int main(void)
> char *shm_name;
>
> name_max = pathconf("/", _PC_NAME_MAX);
> +
> + if (name_max == -1) {
> + perror("An error occurs when calling pathconf()");
I've shortened this error message to "pathconf() failed" here and in
10-2.c and pushed both patches, thanks.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2015-08-05 12:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 5:33 [LTP] [PATCH 2/2] open_posix/shm_unlink: sanity checking after calling pathconf Maninder Singh
2015-08-05 12:59 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805125903.GD31234@rei.suse.de \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=maninder1.s@samsung.com \
--cc=pankaj.m@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox