From: Cyril Hrubis <chrubis@suse.cz>
To: Jan Kara <jack@suse.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v2] inotify: Add test for inotify mark destruction race
Date: Tue, 11 Aug 2015 16:14:32 +0200 [thread overview]
Message-ID: <20150811141432.GA21861@rei.suse.de> (raw)
In-Reply-To: <1439215460-15670-1-git-send-email-jack@suse.com>
Hi!
Pushed with following changes:
* Added GPL header at the start of the file
* Removed cleanup parameter from SAFE calls in child
because if one of the calls in child fails the temporary
directory would be deleted, then parent would attempt to
remove the directory and that will fail horribly.
* Moved to body of the test to separate function to spare
some indentation.
* Used tst_fork() instead of fork() (flushes userspace stdio buffers
before fork, otherwise messages from test may end up duplicated
several times)
* Used ltp_syscall() instead of syscall() which handles ENOSYS etc.
* Added inotify06 binary to gitignore.
And checked that it still Opses kernel after these changes, thanks.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2015-08-11 14:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 14:04 [LTP] [PATCH v2] inotify: Add test for inotify mark destruction race Jan Kara
2015-08-11 14:14 ` Cyril Hrubis [this message]
[not found] ` <20150811142035.GD2659@quack.suse.cz>
2015-08-25 9:29 ` Cyril Hrubis
[not found] ` <20150825103803.GA15280@quack.suse.cz>
2015-08-25 11:29 ` Cyril Hrubis
2016-04-14 2:06 ` Xiaoguang Wang
2016-04-14 8:15 ` Jan Kara
2016-04-14 8:14 ` Xiaoguang Wang
2016-04-14 8:46 ` Jan Kara
2016-04-18 3:37 ` Xiaoguang Wang
2016-04-19 13:05 ` Jan Kara
2016-04-26 10:42 ` Jan Kara
2016-04-27 4:48 ` Xiaoguang Wang
2016-04-27 7:58 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150811141432.GA21861@rei.suse.de \
--to=chrubis@suse.cz \
--cc=jack@suse.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox