From: Cyril Hrubis <chrubis@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH 3/3] pounder/cpufreq: Skip the test if processors are not supported by cpufreq
Date: Thu, 20 Aug 2015 17:58:53 +0200 [thread overview]
Message-ID: <20150820155853.GC5144@rei.suse.de> (raw)
In-Reply-To: <1439887006-17985-3-git-send-email-liwang@redhat.com>
Hi!
> # Do any CPU support cpufreq?
> -#CPUFREQ_ENABLED_CPUS=`/bin/ls -lad /sys/devices/system/cpu/cpu*/cpufreq 2> /dev/null | wc -l`
> +CPUFREQ_ENABLED_CPUS=`/bin/ls -lad /sys/devices/system/cpu/cpu*/cpufreq 2> /dev/null | wc -l`
Calling ls by full path is simply wrong.
> -#if [ "$CPUFREQ_ENABLED_CPUS" -lt 1 ]; then
> -# echo "None of your CPUs support cpufreq. Bye."
> -# exit 255
> -#fi
> +if [ "$CPUFREQ_ENABLED_CPUS" -lt 1 ]; then
> + echo "None of your CPUs support cpufreq. Bye."
> + exit 255
> +fi
This part of code was specially disabled in one commit, unfortunately it
does not say why exactly it was disabled. So I'm hesitant to enable it
unless we are sure that the code actually works fine on several
distributions.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2015-08-20 15:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 8:36 [LTP] [PATCH 1/3] ltp/tools: remove the scripts/numa_test.sh file Li Wang
2015-08-18 8:36 ` [LTP] [PATCH 2/3] ltp/pounder: Don't let the testing log output to /dev/tty Li Wang
2015-08-18 8:36 ` [LTP] [PATCH 3/3] pounder/cpufreq: Skip the test if processors are not supported by cpufreq Li Wang
2015-08-20 15:58 ` Cyril Hrubis [this message]
2015-08-20 15:52 ` [LTP] [PATCH 2/3] ltp/pounder: Don't let the testing log output to /dev/tty Cyril Hrubis
2015-08-20 15:44 ` [LTP] [PATCH 1/3] ltp/tools: remove the scripts/numa_test.sh file Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150820155853.GC5144@rei.suse.de \
--to=chrubis@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox