From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] ftp/ftp02: The case needs to check vsftpd first
Date: Tue, 29 Sep 2015 18:45:30 +0200 [thread overview]
Message-ID: <20150929164530.GA32482@rei.suse.cz> (raw)
In-Reply-To: <1442365546-63246-1-git-send-email-cuibixuan@huawei.com>
Hi!
> ---
> testcases/network/tcp_cmds/ftp/ftp02 | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/testcases/network/tcp_cmds/ftp/ftp02 b/testcases/network/tcp_cmds/ftp/ftp02
> index 92e7944..6b84f22 100755
> --- a/testcases/network/tcp_cmds/ftp/ftp02
> +++ b/testcases/network/tcp_cmds/ftp/ftp02
> @@ -38,7 +38,7 @@
>
> setup()
> {
> - tst_check_cmds expect ftp useradd userdel
> + tst_check_cmds expect ftp useradd userdel vsftpd
> export TEST_USER="ftpuser2"
I see that rest of the ftp testcases that uses vsftpd has it in
tst_check_cmds. However it would be cleaner to add this check to the top
of the ftp_setup file so that it's called at the moment the file is
sourced and remove it from the individual testcases.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2015-09-29 16:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 1:05 [LTP] [PATCH] ftp/ftp02: The case needs to check vsftpd first Cui Bixuan
2015-09-29 16:45 ` Cyril Hrubis [this message]
2015-10-08 8:55 ` [LTP] [PATCH v2] ftp: Move commands check to ftp_setup Cui Bixuan
2015-10-08 13:26 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150929164530.GA32482@rei.suse.cz \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox