From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] sched_getattr/sched_getattr01: Use macro definitions to replace numbers
Date: Mon, 26 Oct 2015 16:29:11 +0100 [thread overview]
Message-ID: <20151026152911.GA6772@rei> (raw)
In-Reply-To: <1445343078-145058-1-git-send-email-cuibixuan@huawei.com>
Hi!
> Use 'RUNTIME_VAL','PERIOD_VAL' and 'DEADLINE_VAL' to set attr
>
> Signed-off-by: Cui Bixuan <cuibixuan@huawei.com>
> ---
> .../syscalls/sched_getattr/sched_getattr01.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c b/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c
> index 267b8b1..bf6c5b6 100644
> --- a/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c
> +++ b/testcases/kernel/syscalls/sched_getattr/sched_getattr01.c
> @@ -38,9 +38,9 @@ void *run_deadline(void *data LTP_ATTRIBUTE_UNUSED)
>
> /* This creates a 10ms/30ms reservation */
> attr.sched_policy = SCHED_DEADLINE;
> - attr.sched_runtime = 10 * 1000 * 1000;
> - attr.sched_period = 30 * 1000 * 1000;
> - attr.sched_deadline = 30 * 1000 * 1000;
> + attr.sched_runtime = RUNTIME_VAL;
> + attr.sched_period = PERIOD_VAL;
> + attr.sched_deadline = DEADLINE_VAL;
Looking at the test it also misses GPL header in a comment. Can you
please send a patch that adds it as well?
(sorry for not catching that earlier)
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2015-10-26 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 12:11 [LTP] [PATCH] sched_getattr/sched_getattr01: Use macro definitions to replace numbers Cui Bixuan
2015-10-26 15:29 ` Cyril Hrubis [this message]
2015-10-27 9:32 ` [LTP] [PATCH v2] " Cui Bixuan
2015-10-27 12:48 ` Cyril Hrubis
2015-10-28 0:45 ` Cui Bixuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151026152911.GA6772@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox