public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] mkfs01 testcases issue
Date: Tue, 5 Jan 2016 15:21:15 +0100	[thread overview]
Message-ID: <20160105142114.GA8939@rei.lan> (raw)
In-Reply-To: <20160105134815.GB32659@rei.lan>

Hi!
> > While running LTP commands testcases,these three 
> > tests(mkfs01_msdos,mkfs01_vfat,mkswap01) sometimes failed.
> > It is because that mkfs.vfat/mkswap on the test block device which is 
> > made as btrfs( in previous mkfs01_btrfs test) does not work.
> > blkid still show "TYPE="btrfs" after mkfs.vfat/mkswap.
> > Seems the issue is only reproduced with a very small size of block 
> > device(less than 20M).
> > Does anyone hit similar issue,is it a kernel or btrfs bug?

And looks like mkswap has been fixed allready in:

commit c1f1b301718ec0f5ffeae5b631c3ff38455b9ccd
Author: Milan Broz <mbroz@redhat.com>
Date:   Mon Sep 10 12:58:39 2012 +0200

    mkswap: wipe old signature if there is no part table by default

    Historically mkswap avoids wiping any signature on "whole disk",
    until force option is given.

    While the idea is that it should not wipe possible boot loader,
    in reality it leads to many situations where e.g. LUKS device
    is overwritten but still can be detected as LUKS (but unusable).

    Patch chnges behaviour that only if partition table is detected,
    signatures are not wiped.

    Also it removes check for block device - loop device can now
    map partitions in-kernel, so using mkswap on disk image in file
    should behave the same as on disk.

    Also it adds warning that know signature was wiped.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2016-01-05 14:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-25 17:37 [LTP] mkfs01 testcases issue Shuang Qiu
2016-01-05 13:48 ` Cyril Hrubis
2016-01-05 14:21   ` Cyril Hrubis [this message]
2016-01-05 14:35   ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160105142114.GA8939@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox