From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3] commands/which: Added new testcase to test which(1).
Date: Tue, 5 Jan 2016 16:27:03 +0100 [thread overview]
Message-ID: <20160105152703.GD8939@rei.lan> (raw)
In-Reply-To: <1450249273-7498-1-git-send-email-fenggw-fnst@cn.fujitsu.com>
Hi!
Pushed with this change:
@@ -47,9 +47,6 @@ cleanup()
which_verify()
{
- local which_op=$1
-
- shift
until [ -z "$1" ]
do
grep -q "$1" temp
@@ -90,7 +87,7 @@ which_test()
if [ $# -gt 2 ]; then
shift 2
- which_verify "$which_op" "$@"
+ which_verify "$@"
if [ $? -ne 0 ]; then
tst_resm TFAIL "'${which_cmd}' failed, not expected."
return
Since the $which_op was unused in the fucntion.
Thanks.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2016-01-05 15:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 11:55 [LTP] [PATCH] commands/which: Added new testcase to test which(1) Guangwen Feng
2015-12-03 13:33 ` Cyril Hrubis
2015-12-04 7:50 ` Guangwen Feng
2015-12-04 9:12 ` [LTP] [PATCH v2] " Guangwen Feng
2015-12-15 13:47 ` Cyril Hrubis
2015-12-16 7:01 ` [LTP] [PATCH v3] " Guangwen Feng
2016-01-05 15:27 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160105152703.GD8939@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox