public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] [PATCH] device-drivers/uaccess: use linux/uaccess.h
@ 2016-01-19 15:47 Stanislav Kholmanskikh
  2016-01-19 17:21 ` Cyril Hrubis
  0 siblings, 1 reply; 3+ messages in thread
From: Stanislav Kholmanskikh @ 2016-01-19 15:47 UTC (permalink / raw)
  To: ltp

The current code fails to build on sparc64.

It turns out that <linux/uaccess.h> is a better candidate than
<asm-generic/uaccess.h>, since the former takes into account
possible architecture-specific changes.

Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
---
 .../kernel/device-drivers/uaccess/ltp_uaccess.c    |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/testcases/kernel/device-drivers/uaccess/ltp_uaccess.c b/testcases/kernel/device-drivers/uaccess/ltp_uaccess.c
index e628ba9..a9a06e9 100644
--- a/testcases/kernel/device-drivers/uaccess/ltp_uaccess.c
+++ b/testcases/kernel/device-drivers/uaccess/ltp_uaccess.c
@@ -21,7 +21,7 @@
 
 #include <linux/module.h>
 #include <linux/device.h>
-#include <asm-generic/uaccess.h>
+#include <linux/uaccess.h>
 #include "ltp_uaccess.h"
 
 MODULE_AUTHOR("Alexey Kodanev <alexey.kodanev@oracle.com>");
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [LTP] [PATCH] device-drivers/uaccess: use linux/uaccess.h
  2016-01-19 15:47 [LTP] [PATCH] device-drivers/uaccess: use linux/uaccess.h Stanislav Kholmanskikh
@ 2016-01-19 17:21 ` Cyril Hrubis
  2016-01-20 12:20   ` Stanislav Kholmanskikh
  0 siblings, 1 reply; 3+ messages in thread
From: Cyril Hrubis @ 2016-01-19 17:21 UTC (permalink / raw)
  To: ltp

Hi!
>  #include <linux/module.h>
>  #include <linux/device.h>
> -#include <asm-generic/uaccess.h>
> +#include <linux/uaccess.h>

Looks good, acked.

Btw, grepping "uaccess.h" in linux/drivers/ shows either linux/uaccess.h
or asm/uaccess.h but no asm-generic/uaccess.h.

-- 
Cyril Hrubis
chrubis@suse.cz

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [LTP] [PATCH] device-drivers/uaccess: use linux/uaccess.h
  2016-01-19 17:21 ` Cyril Hrubis
@ 2016-01-20 12:20   ` Stanislav Kholmanskikh
  0 siblings, 0 replies; 3+ messages in thread
From: Stanislav Kholmanskikh @ 2016-01-20 12:20 UTC (permalink / raw)
  To: ltp



On 01/19/2016 08:21 PM, Cyril Hrubis wrote:
> Hi!
>>   #include <linux/module.h>
>>   #include <linux/device.h>
>> -#include <asm-generic/uaccess.h>
>> +#include <linux/uaccess.h>
>
> Looks good, acked.

Thank you. Committed.

>
> Btw, grepping "uaccess.h" in linux/drivers/ shows either linux/uaccess.h
> or asm/uaccess.h but no asm-generic/uaccess.h.
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-01-20 12:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-19 15:47 [LTP] [PATCH] device-drivers/uaccess: use linux/uaccess.h Stanislav Kholmanskikh
2016-01-19 17:21 ` Cyril Hrubis
2016-01-20 12:20   ` Stanislav Kholmanskikh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox