From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] commands/insmod: Added new testcase to test insmod(8)
Date: Wed, 27 Jan 2016 17:28:46 +0100 [thread overview]
Message-ID: <20160127162845.GA1358@rei.lan> (raw)
In-Reply-To: <1450422438-8798-2-git-send-email-fenggw-fnst@cn.fujitsu.com>
Hi!
> +setup()
> +{
> + tst_require_root
> +
> + tst_check_cmds rmmod insmod
> +
> + if ! [ -e ./test_insmod01.ko ]; then
> + tst_brkm TCONF "'test_insmod01.ko' not found"
> + fi
We should really copy the behavior of tst_module_exist() from C library
here, i.e. add a function to test.sh that will return a path to the
module in case that it exists. I can write the function if needed.
> diff --git a/testcases/commands/insmod/test_insmod01.c b/testcases/commands/insmod/test_insmod01.c
And I would prefix the module name with ltp_ as well so that it's clear
where it came from.
The rest looks good.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-01-27 16:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 7:07 [LTP] [PATCH 1/2] commands/lsmod: Added new testcase to test lsmod(8) Guangwen Feng
2015-12-18 7:07 ` [LTP] [PATCH 2/2] commands/insmod: Added new testcase to test insmod(8) Guangwen Feng
2016-01-27 16:28 ` Cyril Hrubis [this message]
2016-01-28 9:42 ` Guangwen Feng
2016-03-15 8:03 ` [LTP] [PATCH v2] commands/insmod: add " Guangwen Feng
2016-04-18 2:33 ` Guangwen Feng
2016-04-18 15:44 ` Cyril Hrubis
2016-04-22 6:28 ` [LTP] [PATCH v3] " Guangwen Feng
2016-05-10 16:28 ` Cyril Hrubis
2016-01-27 16:11 ` [LTP] [PATCH 1/2] commands/lsmod: Added new testcase to test lsmod(8) Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127162845.GA1358@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox