[LTP] [PATCH] numa_node_size: drop definition of numa_exit_on_error

[LTP] [PATCH] numa_node_size: drop definition of numa_exit_on_error

[Jan Stancek]

numa_exit_on_error is defined by numactl library in libnuma.c,
at least since version 0.9. Re-defining it in test can cause
compile problems.

Reported-by: M.Srikanth Kumar <srikanth007m@gmail.com>
Signed-off-by: Jan Stancek <jstancek@redhat.com>
---
 testcases/kernel/numa/numa_node_size.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/testcases/kernel/numa/numa_node_size.c b/testcases/kernel/numa/numa_node_size.c
index 6338bc73c864..378a1d5d1e54 100644
--- a/testcases/kernel/numa/numa_node_size.c
+++ b/testcases/kernel/numa/numa_node_size.c
@@ -38,7 +38,6 @@
 #include <numa.h>
 #endif
 
-int numa_exit_on_error = 0;
 char *fmt_mem(unsigned long long mem, char *buf)
 {
 	if (mem == -1L)
-- 
1.8.3.1

[LTP] [PATCH] numa_node_size: drop definition of numa_exit_on_error

[Cyril Hrubis]

Hi!
> numa_exit_on_error is defined by numactl library in libnuma.c,
> at least since version 0.9. Re-defining it in test can cause
> compile problems.

I've tried to rebuild LTP without the line in question on couple of SUSE
distros and it haven't caused any problems. I wonder why it wasn't
failing the compilation before though, the variable is defined right in
the libnuma.c in the library.

-- 
Cyril Hrubis
chrubis@suse.cz

[LTP] [PATCH] numa_node_size: drop definition of numa_exit_on_error

[Jan Stancek]

----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: ltp@lists.linux.it
> Sent: Thursday, 28 January, 2016 2:41:27 PM
> Subject: Re: [LTP] [PATCH] numa_node_size: drop definition of numa_exit_on_error
> 
> Hi!
> > numa_exit_on_error is defined by numactl library in libnuma.c,
> > at least since version 0.9. Re-defining it in test can cause
> > compile problems.
> 
> I've tried to rebuild LTP without the line in question on couple of SUSE
> distros and it haven't caused any problems. I wonder why it wasn't
> failing the compilation before though, the variable is defined right in
> the libnuma.c in the library.

Linker doesn't seem to mind when linking against shared library.
His build had --static, so I'm guessing noone has tried (and reported) that before.

Regards,
Jan

> 
> --
> Cyril Hrubis
> chrubis@suse.cz
>