public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] mmap16: fix ETIMEDOUT error if test device is too large
Date: Wed, 9 Mar 2016 10:22:00 +0800	[thread overview]
Message-ID: <20160309022200.GC11419@eguan.usersys.redhat.com> (raw)
In-Reply-To: <1457444133-5671-2-git-send-email-zlang@redhat.com>

On Tue, Mar 08, 2016 at 09:35:33PM +0800, Zorro Lang wrote:
> mmap16 will wait DEFAULT_MSEC_TIMEOUT=10000 msec, for parent
> process full the test device(-b $DEVICE). But if the device
> size is too large, this case will hit ETIMEDOUT error.
> 
> For reproduce the bug of mmap16, it don't need too large device.
> So I limit the fs size in 100M.
> 
> Signed-off-by: Zorro Lang <zlang@redhat.com>
> ---
>  testcases/kernel/syscalls/mmap/mmap16.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/mmap/mmap16.c b/testcases/kernel/syscalls/mmap/mmap16.c
> index c5828ea..f8fbd50 100644
> --- a/testcases/kernel/syscalls/mmap/mmap16.c
> +++ b/testcases/kernel/syscalls/mmap/mmap16.c
> @@ -143,8 +143,6 @@ static void do_test(void)
>  
>  static void setup(void)
>  {
> -	const char *fs_opts[3] = {"-b", "1024", NULL};
> -
>  	tst_sig(FORK, DEF_HANDLER, NULL);
>  	tst_require_root();
>  
> @@ -158,7 +156,7 @@ static void setup(void)
>  	device = tst_acquire_device(cleanup);
>  	if (!device)
>  		tst_brkm(TCONF, cleanup, "Failed to obtain block device");
> -	tst_mkfs(cleanup, device, fs_type, fs_opts);
> +	tst_mkfs(cleanup, device, fs_type, NULL, "100m", "1024");

Should be calling tst_mkfs_sized() instead?

Thanks,
Eryu
>  
>  	SAFE_MKDIR(cleanup, MNTPOINT, 0755);
>  	/*
> -- 
> 2.5.0
> 
> 
> -- 
> Mailing list info: http://lists.linux.it/listinfo/ltp

  reply	other threads:[~2016-03-09  2:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08 13:35 [LTP] [PATCH 1/2] lib/tst_mkfs: new tst_mkfs_sized function for create appointed size fs Zorro Lang
2016-03-08 13:35 ` [LTP] [PATCH 2/2] mmap16: fix ETIMEDOUT error if test device is too large Zorro Lang
2016-03-09  2:22   ` Eryu Guan [this message]
2016-03-09  3:12     ` Zirong Lang
2016-03-09 13:07 ` [LTP] [PATCH 1/2] lib/tst_mkfs: new tst_mkfs_sized function for create appointed size fs Cyril Hrubis
2016-03-09 15:31   ` Zirong Lang
2016-03-09 15:52     ` Cyril Hrubis
2016-03-09 16:05       ` Zirong Lang
2016-03-09 16:09         ` Cyril Hrubis
2016-03-09 16:30           ` Zirong Lang
2016-03-09 17:43             ` Cyril Hrubis
2016-03-10  1:45               ` Zirong Lang
2016-03-10 10:04                 ` Cyril Hrubis
2016-03-10 12:00                   ` Zirong Lang
2016-03-10 12:19                     ` Cyril Hrubis
2016-03-10 13:30                       ` Zirong Lang
2016-03-10 14:06                         ` Cyril Hrubis
2016-03-10 16:24                           ` Zirong Lang
2016-03-14 17:15                             ` Cyril Hrubis
2016-03-09 16:01     ` Zirong Lang
2016-03-09 13:09 ` Cyril Hrubis
2016-03-09 15:09   ` Zirong Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160309022200.GC11419@eguan.usersys.redhat.com \
    --to=eguan@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox