From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] lib/tst_mkfs: new tst_mkfs_sized function for create appointed size fs
Date: Thu, 10 Mar 2016 15:06:53 +0100 [thread overview]
Message-ID: <20160310140653.GA19672@rei.lan> (raw)
In-Reply-To: <762780060.28180858.1457616611675.JavaMail.zimbra@redhat.com>
Hi!
> > > 2) Generally most QE will prepare some partitions or some special
> > > device(FC, SAS...)
> > > in his test machine, and use them for many different test suit(LTP,
> > > xfstests ...).
> > > These partitions or devices maybe 15G, 80G, 1T, 2T... they always pass them
> > > as test
> > > devices directly. I think we shouldn't say "NO, you can't pass a device
> > > more than
> > > 1G to LTP, that will cause failures.", I think LTP should deal with big
> > > test device
> > > problem, so mkfs_sized is needed.
> >
> > I do not agree. Since if you do not pass any device to LTP, it will
> > simply create small enough loopback device. So in this case the solution
> > is simply not passing any device to LTP at all.
>
> Oh, sorry I don't know LTP will create small loop device by itself. So do you
> still want to fix this ETIMEDOUT problem? Or we just say "please don't give
> outside device to LTP?" or "please give a small enough device to LTP -b device"
I still do, since it's reasonably easy to fix and 1GB block device is
not that big to begin with.
> BTW, if LTP will create small loop device by itself, I can't make mmap16 to create
> a 100M ext4. I think it maybe too big for LTP small loop device. I will test and
> change my recent patch
Ah looks like there is a bug. Since the default LTP device size was
changed to 100MB in lib/tst_device.c and in testcases/lib/test.sh but
not in the runltp (which is because new enough btrfs needs at least
100MB for filesystem).
But the mmap16 test should work with as small device as possible, which
would be 20MB.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-03-10 14:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 13:35 [LTP] [PATCH 1/2] lib/tst_mkfs: new tst_mkfs_sized function for create appointed size fs Zorro Lang
2016-03-08 13:35 ` [LTP] [PATCH 2/2] mmap16: fix ETIMEDOUT error if test device is too large Zorro Lang
2016-03-09 2:22 ` Eryu Guan
2016-03-09 3:12 ` Zirong Lang
2016-03-09 13:07 ` [LTP] [PATCH 1/2] lib/tst_mkfs: new tst_mkfs_sized function for create appointed size fs Cyril Hrubis
2016-03-09 15:31 ` Zirong Lang
2016-03-09 15:52 ` Cyril Hrubis
2016-03-09 16:05 ` Zirong Lang
2016-03-09 16:09 ` Cyril Hrubis
2016-03-09 16:30 ` Zirong Lang
2016-03-09 17:43 ` Cyril Hrubis
2016-03-10 1:45 ` Zirong Lang
2016-03-10 10:04 ` Cyril Hrubis
2016-03-10 12:00 ` Zirong Lang
2016-03-10 12:19 ` Cyril Hrubis
2016-03-10 13:30 ` Zirong Lang
2016-03-10 14:06 ` Cyril Hrubis [this message]
2016-03-10 16:24 ` Zirong Lang
2016-03-14 17:15 ` Cyril Hrubis
2016-03-09 16:01 ` Zirong Lang
2016-03-09 13:09 ` Cyril Hrubis
2016-03-09 15:09 ` Zirong Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160310140653.GA19672@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox