public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] Question about perf_event_open/Cap_bounds/su01 test cases
Date: Mon, 14 Mar 2016 19:18:03 +0100	[thread overview]
Message-ID: <20160314181803.GE3364@rei.lan> (raw)
In-Reply-To: <AF04265A3FC2B144B9892F621A394E13EA3E2813@tethys>

Hi!
> Specifically, to Cyril comments:
> 
> > The fanotify06 failure is likely kernel bug fixed in:
> 
> After to use the latest LTP, this error disappear. The test is marked as PASS with TCONF. But the others test cases: fanotify01, fanotify02 and fanotify04 are marked as FAIL with the message "Fanotify is not configured in this kernel.". I don't understand why with this message, is still marked as fail? [please, refer details to https://justpaste.it/s5c3]. Thanks for looking at this issue and give the details of bug solution. Appreciated.

Ah that is because the test cleanup closes the fd_notify file descriptor
unconditionally while it should be only closed if it's greater than
zero.

This should fix the WARNING that causes the test to fail if fanotify is not
compiled in kernel:

 static void cleanup(void)
 {
-       if (close(fd_notify) == -1)
+       if (fd_notify > 0 && close(fd_notify) == -1)
                tst_resm(TWARN, "close(%d) failed", fd_notify);
 
        tst_rmdir();

I will push a patch with fixes for the testcasee tomorrow. Thanks for reporting
it.

-- 
Cyril Hrubis
chrubis@suse.cz

  parent reply	other threads:[~2016-03-14 18:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-09 10:40 [LTP] Question about perf_event_open/Cap_bounds/su01 test cases Julio Cruz Barroso
2016-03-09 12:08 ` Jan Stancek
2016-03-09 13:52   ` Cyril Hrubis
2016-03-09 14:08 ` Cyril Hrubis
2016-03-11 13:35   ` Julio Cruz Barroso
2016-03-11 15:35     ` Jan Stancek
2016-03-12 12:01       ` Julio Cruz Barroso
2016-03-12 13:45         ` Jan Stancek
2016-03-13 11:39           ` Julio Cruz Barroso
2016-03-14 12:10             ` Jan Stancek
2016-03-15 10:35               ` Julio Cruz Barroso
2016-03-14 18:18     ` Cyril Hrubis [this message]
2016-03-15 15:07       ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160314181803.GE3364@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox