From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/2] lib: add safe_pthread_create() & safe_pthread_join()
Date: Thu, 7 Apr 2016 13:35:31 +0200 [thread overview]
Message-ID: <20160407113531.GA16682@rei> (raw)
In-Reply-To: <1460016651-24181-1-git-send-email-alexey.kodanev@oracle.com>
Hi!
> +int safe_pthread_join(const char *file, const int lineno,
> + pthread_t thread_id, void **retval)
> +{
> + int rval;
> +
> + rval = pthread_join(thread_id, retval);
> +
> + if (rval) {
> + tst_brk_(file, lineno, TBROK,
> + "pthread_join(%lu,%p) failed: %s", thread_id, retval,
> + tst_strerrno(rval));
Technically the thread_id does not need to be numeric type, POSIX
defines it as a opaque, may be structure as well.
But on the other hand I doubt that there is a Linux libc implementation
that actually defines it to be anything else than long int.
> + }
> +
> + return rval;
> +}
Otherwise this looks fine.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-04-07 11:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 8:10 [LTP] [PATCH v2 1/2] lib: add safe_pthread_create() & safe_pthread_join() Alexey Kodanev
2016-04-07 8:10 ` [LTP] [PATCH v2 2/2] syscalls/fcntl: add new test for open file description locks Alexey Kodanev
2016-04-07 12:38 ` Cyril Hrubis
2016-04-12 10:01 ` Alexey Kodanev
2016-04-07 11:35 ` Cyril Hrubis [this message]
2016-04-07 16:42 ` [LTP] [PATCH v2 1/2] lib: add safe_pthread_create() & safe_pthread_join() Alexey Kodanev
2016-04-11 14:46 ` Cyril Hrubis
2016-04-12 9:21 ` Alexey Kodanev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407113531.GA16682@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox