From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] ptrace/ptrace05: preventing kill other processes if fork failed
Date: Tue, 12 Apr 2016 12:08:59 +0200 [thread overview]
Message-ID: <20160412100858.GC24915@rei.lan> (raw)
In-Reply-To: <20160412030734.GA11627@localhost.localdomain>
Hi!
> If fork failed, we should try next signum. Or the kill(-1, 9) on line
> 196 will kill a lot of processes.
>
> Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
> ---
> testcases/kernel/syscalls/ptrace/ptrace05.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/syscalls/ptrace/ptrace05.c b/testcases/kernel/syscalls/ptrace/ptrace05.c
> index d610cc0..e717319 100644
> --- a/testcases/kernel/syscalls/ptrace/ptrace05.c
> +++ b/testcases/kernel/syscalls/ptrace/ptrace05.c
> @@ -99,7 +99,7 @@ int main(int argc, char **argv)
> switch (child = fork()) {
> case -1:
> tst_resm(TBROK | TERRNO, "Failed to fork properly.");
> - break;
> + continue;
I would just change this to tst_brkm(). There is no point in continuing
the test if fork() starts failing.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-04-12 10:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 3:07 [LTP] [PATCH] ptrace/ptrace05: preventing kill other processes if fork failed Han Pingtian
2016-04-12 10:08 ` Cyril Hrubis [this message]
2016-04-12 13:19 ` Han Pingtian
2016-04-12 15:42 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412100858.GC24915@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox