From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] waitpid/waitpid03: break test if fork failed
Date: Wed, 13 Apr 2016 14:55:35 +0200 [thread overview]
Message-ID: <20160413125535.GF10941@rei.lan> (raw)
In-Reply-To: <20160413065818.GF17476@localhost.localdomain>
Hi!
> Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
> ---
> testcases/kernel/syscalls/waitpid/waitpid03.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/syscalls/waitpid/waitpid03.c b/testcases/kernel/syscalls/waitpid/waitpid03.c
> index 2599a92..7e9d45c 100644
> --- a/testcases/kernel/syscalls/waitpid/waitpid03.c
> +++ b/testcases/kernel/syscalls/waitpid/waitpid03.c
> @@ -106,7 +106,16 @@ int main(int argc, char **argv)
> if (DEBUG)
> tst_resm(TINFO, "child # %d", ikids);
> } else if (pid[ikids] == -1) {
> - tst_resm(TFAIL, "cannot open fork #%d", ikids);
> + int i;
> +
> + tst_resm(TBROK|TERRNO, "cannot open fork #%d",
> + ikids);
> +
> + for (i = 1; i < ikids; i++)
> + kill(pid[i], 9);
> +
> + cleanup();
> + tst_exit();
This one is ugly. Why don't we kill the children in the test cleanup()
here as well. This should be easy, just store the number of allready
forked kids in a global variable and reset it to zero right after they
were killed in the main loop.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-04-13 12:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 13:22 [LTP] [PATCH] waitpid/waitpid03: break test if fork failed Han Pingtian
2016-04-12 15:52 ` Cyril Hrubis
2016-04-13 3:29 ` Han Pingtian
2016-04-13 12:51 ` Cyril Hrubis
2016-04-13 6:58 ` Han Pingtian
2016-04-13 12:55 ` Cyril Hrubis [this message]
2016-04-14 3:09 ` Han Pingtian
2016-04-19 11:34 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160413125535.GF10941@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox